This is an automated email from the ASF dual-hosted git repository.
coheigea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cxf.git
The following commit(s) were added to refs/heads/master by this push:
new d3b60a4 Finished PMD junit work
d3b60a4 is described below
commit d3b60a4df7a5081bb62e80edef35aa456dd3fd19
Author: Colm O hEigeartaigh <[email protected]>
AuthorDate: Wed Feb 13 16:58:50 2019 +0000
Finished PMD junit work
---
.../cxf/binding/coloc/ColocMessageObserverTest.java | 15 +++++++--------
.../cxf/binding/coloc/ColocOutInterceptorTest.java | 17 ++++++++---------
.../org/apache/cxf/binding/coloc/ColocUtilTest.java | 21 +++++++++------------
.../interceptor/XMLMessageInInterceptorTest.java | 3 +--
.../cxf/aegis/type/basic/DynamicProxyTest.java | 5 +++--
.../java/org/apache/cxf/jaxws/JaxWsClientTest.java | 2 +-
.../cxf/jaxws/handler/HandlerChainInvokerTest.java | 4 ++--
.../jaxws/provider/ProviderServiceFactoryTest.java | 5 +++--
.../apache/cxf/javascript/JsHttpRequestTest.java | 11 ++++-------
.../provider/aegis/AegisElementProviderTest.java | 10 +++++-----
.../jose/jws/JwsCompactReaderWriterTest.java | 4 ++--
.../http_jetty/spring/ApplicationContextTest.java | 6 +++---
.../netty/server/spring/ApplicationContextTest.java | 5 +++--
.../spring/ApplicationContextTest.java | 7 ++++---
.../cxf/transport/jms/uri/JMSEndpointTest.java | 2 +-
.../cxf/systest/jaxws/ClientServerMiscTest.java | 2 +-
.../oauth2/grants/IntrospectionServiceTest.java | 5 +++--
.../cxf/systest/https/conduit/HTTPSConduitTest.java | 4 ++--
.../ManualHttpMulitplexClientServerTest.java | 7 +++----
.../MultiplexHttpAddressClientServerTest.java | 3 +--
.../jaxws/wsdl11/JAXWSDefinitionBuilderTest.java | 4 ++--
21 files changed, 68 insertions(+), 74 deletions(-)
diff --git
a/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocMessageObserverTest.java
b/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocMessageObserverTest.java
index f846abf..1925e08 100644
---
a/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocMessageObserverTest.java
+++
b/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocMessageObserverTest.java
@@ -45,8 +45,9 @@ import org.junit.After;
import org.junit.Before;
import org.junit.Test;
-import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertTrue;
public class ColocMessageObserverTest {
private IMocksControl control = EasyMock.createNiceControl();
@@ -129,12 +130,10 @@ public class ColocMessageObserverTest {
Exchange inEx = inMsg.getExchange();
assertNotNull("Should Have a valid Exchange", inEx);
- assertEquals("Message.REQUESTOR_ROLE should be false",
- Boolean.FALSE,
- inMsg.get(Message.REQUESTOR_ROLE));
- assertEquals("Message.INBOUND_MESSAGE should be true",
- Boolean.TRUE,
- inMsg.get(Message.INBOUND_MESSAGE));
+ assertFalse("Message.REQUESTOR_ROLE should be false",
+ (Boolean)inMsg.get(Message.REQUESTOR_ROLE));
+ assertTrue("Message.INBOUND_MESSAGE should be true",
+ (Boolean)inMsg.get(Message.INBOUND_MESSAGE));
assertNotNull("Chain should be set", inMsg.getInterceptorChain());
Exchange ex1 = msg.getExchange();
assertNotNull("Exchange should be set", ex1);
@@ -155,4 +154,4 @@ public class ColocMessageObserverTest {
return new ArrayList<Interceptor<? extends Message>>();
}
}
-}
\ No newline at end of file
+}
diff --git
a/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocOutInterceptorTest.java
b/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocOutInterceptorTest.java
index 6bf3637..1b9b01a 100644
---
a/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocOutInterceptorTest.java
+++
b/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocOutInterceptorTest.java
@@ -60,6 +60,7 @@ import org.junit.Test;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNotSame;
+import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
public class ColocOutInterceptorTest {
@@ -227,8 +228,7 @@ public class ColocOutInterceptorTest {
control.replay();
colocOut.handleMessage(msg);
- assertEquals("COLOCATED property should be set",
- Boolean.TRUE, msg.get(COLOCATED));
+ assertTrue("COLOCATED property should be set",
(Boolean)msg.get(COLOCATED));
assertEquals("Message.WSDL_OPERATION property should be set",
op, msg.get(Message.WSDL_OPERATION));
assertEquals("Message.WSDL_INTERFACE property should be set",
@@ -268,14 +268,13 @@ public class ColocOutInterceptorTest {
colocOut.invokeInboundChain(ex, ep);
Message inMsg = ex.getInMessage();
assertNotSame(msg, inMsg);
- assertEquals("Requestor role should be set to true.",
- Boolean.TRUE, inMsg.get(Message.REQUESTOR_ROLE));
- assertEquals("Inbound Message should be set to true.",
- Boolean.TRUE, inMsg.get(Message.INBOUND_MESSAGE));
+ assertTrue("Requestor role should be set to true.",
+ (Boolean)inMsg.get(Message.REQUESTOR_ROLE));
+ assertTrue("Inbound Message should be set to true.",
+ (Boolean)inMsg.get(Message.INBOUND_MESSAGE));
assertNotNull("Inbound Message should have interceptor chain set.",
inMsg.getInterceptorChain());
- assertEquals("Client Invoke state should be FINISHED",
- Boolean.TRUE, ex.get(ClientImpl.FINISHED));
+ assertTrue("Client Invoke state should be FINISHED",
(Boolean)ex.get(ClientImpl.FINISHED));
control.verify();
}
@@ -575,4 +574,4 @@ public class ColocOutInterceptorTest {
}
}
-}
\ No newline at end of file
+}
diff --git
a/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocUtilTest.java
b/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocUtilTest.java
index 351e76d..daff91a 100644
---
a/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocUtilTest.java
+++
b/rt/bindings/coloc/src/test/java/org/apache/cxf/binding/coloc/ColocUtilTest.java
@@ -53,6 +53,7 @@ import org.junit.Before;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNotSame;
import static org.junit.Assert.assertTrue;
@@ -135,9 +136,7 @@ public class ColocUtilTest {
control.verify();
assertNotNull("Should have chain instance", chain);
Iterator<Interceptor<? extends Message>> iter = chain.iterator();
- assertEquals("Should not have interceptors in chain",
- false,
- iter.hasNext());
+ assertFalse("Should not have interceptors in chain", iter.hasNext());
}
@Test
@@ -168,9 +167,7 @@ public class ColocUtilTest {
control.verify();
assertNotNull("Should have chain instance", chain);
Iterator<Interceptor<? extends Message>> iter = chain.iterator();
- assertEquals("Should not have interceptors in chain",
- false,
- iter.hasNext());
+ assertFalse("Should not have interceptors in chain", iter.hasNext());
assertNotNull("OutFaultObserver should be set",
chain.getFaultObserver());
}
@@ -182,9 +179,9 @@ public class ColocUtilTest {
assertTrue("Should return true", match);
List<FaultInfo> fil1 = new ArrayList<>();
match = ColocUtil.isSameFaultInfo(fil1, null);
- assertEquals("Should not find a match", false, match);
+ assertFalse("Should not find a match", match);
match = ColocUtil.isSameFaultInfo(null, fil1);
- assertEquals("Should not find a match", false, match);
+ assertFalse("Should not find a match", match);
List<FaultInfo> fil2 = new ArrayList<>();
match = ColocUtil.isSameFaultInfo(fil1, fil2);
@@ -198,7 +195,7 @@ public class ColocUtilTest {
FaultInfo fi2 = new FaultInfo(fn2, null, oi);
fi2.setProperty(Class.class.getName(), FaultDetailT.class);
match = ColocUtil.isSameFaultInfo(fil1, fil2);
- assertEquals("Should not find a match", false, match);
+ assertFalse("Should not find a match", match);
FaultInfo fi3 = new FaultInfo(fn2, null, oi);
fi3.setProperty(Class.class.getName(), PingMeFault.class);
@@ -218,9 +215,9 @@ public class ColocUtilTest {
MessageInfo mi1 = new MessageInfo(oi, MessageInfo.Type.INPUT, mn1);
MessageInfo mi2 = new MessageInfo(oi, MessageInfo.Type.INPUT, mn2);
match = ColocUtil.isSameMessageInfo(mi1, null);
- assertEquals("Should not find a match", false, match);
+ assertFalse("Should not find a match", match);
match = ColocUtil.isSameMessageInfo(null, mi2);
- assertEquals("Should not find a match", false, match);
+ assertFalse("Should not find a match", match);
MessagePartInfo mpi = new MessagePartInfo(new QName("", "B"), null);
mpi.setTypeClass(InHeaderT.class);
@@ -231,7 +228,7 @@ public class ColocUtilTest {
mi2.addMessagePart(mpi);
match = ColocUtil.isSameMessageInfo(mi1, mi2);
- assertEquals("Should not find a match", false, match);
+ assertFalse("Should not find a match", match);
mpi.setTypeClass(InHeaderT.class);
match = ColocUtil.isSameMessageInfo(mi1, mi2);
diff --git
a/rt/bindings/xml/src/test/java/org/apache/cxf/binding/xml/interceptor/XMLMessageInInterceptorTest.java
b/rt/bindings/xml/src/test/java/org/apache/cxf/binding/xml/interceptor/XMLMessageInInterceptorTest.java
index 48a75c1..c5f6ae8 100644
---
a/rt/bindings/xml/src/test/java/org/apache/cxf/binding/xml/interceptor/XMLMessageInInterceptorTest.java
+++
b/rt/bindings/xml/src/test/java/org/apache/cxf/binding/xml/interceptor/XMLMessageInInterceptorTest.java
@@ -65,8 +65,7 @@ public class XMLMessageInInterceptorTest extends TestBase {
List<?> list = xmlMessage.getContent(List.class);
assertNotNull(list);
assertEquals("expect 2 param", 2, list.size());
- assertEquals("method input in2 is MyComplexStructType", true,
- list.get(1) instanceof MyComplexStructType);
+ assertTrue("method input in2 is MyComplexStructType", list.get(1)
instanceof MyComplexStructType);
assertTrue("method input in1 is String tli", ((String)
list.get(0)).indexOf("tli") >= 0);
}
diff --git
a/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/basic/DynamicProxyTest.java
b/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/basic/DynamicProxyTest.java
index 9c18d64..9e8849c 100644
---
a/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/basic/DynamicProxyTest.java
+++
b/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/type/basic/DynamicProxyTest.java
@@ -28,6 +28,7 @@ import org.apache.cxf.aegis.xml.stax.ElementReader;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
@@ -58,7 +59,7 @@ public class DynamicProxyTest extends AbstractAegisTest {
data.setName("bigjunk");
data.setUseless(false);
assertEquals("bigjunk", data.getName());
- assertEquals(false, data.isUseless());
+ assertFalse(data.isUseless());
assertTrue(data.hashCode() != 0);
assertEquals(data, data);
@@ -203,4 +204,4 @@ public class DynamicProxyTest extends AbstractAegisTest {
public interface IMyInterface2 {
IMyInterface getMyInterface();
}
-}
\ No newline at end of file
+}
diff --git
a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/JaxWsClientTest.java
b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/JaxWsClientTest.java
index 0100049..00b5dd0 100644
--- a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/JaxWsClientTest.java
+++ b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/JaxWsClientTest.java
@@ -302,7 +302,7 @@ public class JaxWsClientTest extends AbstractJaxWsTest {
public void handleMessage(Message message) throws Fault {
boolean result =
message.getInterceptorChain().doIntercept(message);
- assertEquals("doIntercept not return false", result, false);
+ assertFalse("doIntercept not return false", result);
assertNotNull(message.getContent(Exception.class));
throw new Fault(message.getContent(Exception.class));
}
diff --git
a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/handler/HandlerChainInvokerTest.java
b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/handler/HandlerChainInvokerTest.java
index 6572803..c2affc6 100644
---
a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/handler/HandlerChainInvokerTest.java
+++
b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/handler/HandlerChainInvokerTest.java
@@ -160,7 +160,7 @@ public class HandlerChainInvokerTest {
boolean ret = invoker.invokeLogicalHandlers(false, lmc);
- assertEquals(false, ret);
+ assertFalse(ret);
assertFalse(invoker.isClosed());
assertEquals(1, logicalHandlers[0].getHandleMessageCount());
assertEquals(1, logicalHandlers[1].getHandleMessageCount());
@@ -193,7 +193,7 @@ public class HandlerChainInvokerTest {
boolean ret = invoker.invokeLogicalHandlers(false, lmc);
assertFalse(invoker.isClosed());
- assertEquals(false, ret);
+ assertFalse(ret);
assertEquals(0, logicalHandlers[0].getHandleMessageCount());
assertEquals(1, logicalHandlers[1].getHandleMessageCount());
assertTrue(invoker.isOutbound());
diff --git
a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/provider/ProviderServiceFactoryTest.java
b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/provider/ProviderServiceFactoryTest.java
index 9fabe32..c691132 100644
---
a/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/provider/ProviderServiceFactoryTest.java
+++
b/rt/frontend/jaxws/src/test/java/org/apache/cxf/jaxws/provider/ProviderServiceFactoryTest.java
@@ -42,6 +42,7 @@ import org.apache.hello_world_soap_http.HWSoapMessageProvider;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
@@ -149,7 +150,7 @@ public class ProviderServiceFactoryTest extends
AbstractJaxWsTest {
SoapBindingInfo sb =
(SoapBindingInfo)endpoint.getEndpointInfo().getBinding();
assertEquals("document", sb.getStyle());
- assertEquals(false, bean.isWrapped());
+ assertFalse(bean.isWrapped());
assertEquals(1, sb.getOperations().size());
Node res = invoke(address, LocalTransportFactory.TRANSPORT_ID,
"/org/apache/cxf/jaxws/sayHi.xml");
@@ -187,7 +188,7 @@ public class ProviderServiceFactoryTest extends
AbstractJaxWsTest {
SoapBindingInfo sb =
(SoapBindingInfo)endpoint.getEndpointInfo().getBinding();
assertEquals("document", sb.getStyle());
- assertEquals(false, bean.isWrapped());
+ assertFalse(bean.isWrapped());
assertEquals(1, sb.getOperations().size());
Node res = invoke(address, LocalTransportFactory.TRANSPORT_ID,
"/org/apache/cxf/jaxws/sayHi.xml");
diff --git
a/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/JsHttpRequestTest.java
b/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/JsHttpRequestTest.java
index f31e2c0..667ab69 100644
---
a/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/JsHttpRequestTest.java
+++
b/rt/javascript/javascript-tests/src/test/java/org/apache/cxf/javascript/JsHttpRequestTest.java
@@ -96,12 +96,9 @@ public class JsHttpRequestTest extends AbstractCXFSpringTest
{
testUtilities.rhinoCallInContext("testAsyncHttpFetch2");
boolean notified = notifier.waitForJavascript(2 * 10000);
assertTrue(notified);
- assertEquals("HEADERS_RECEIVED", Boolean.TRUE,
-
testUtilities.rhinoEvaluateConvert("asyncGotHeadersReceived", Boolean.class));
- assertEquals("LOADING", Boolean.TRUE,
- testUtilities.rhinoEvaluateConvert("asyncGotLoading",
Boolean.class));
- assertEquals("DONE", Boolean.TRUE,
- testUtilities.rhinoEvaluateConvert("asyncGotDone",
Boolean.class));
+ assertTrue("HEADERS_RECEIVED",
testUtilities.rhinoEvaluateConvert("asyncGotHeadersReceived", Boolean.class));
+ assertTrue("LOADING",
testUtilities.rhinoEvaluateConvert("asyncGotLoading", Boolean.class));
+ assertTrue("DONE", testUtilities.rhinoEvaluateConvert("asyncGotDone",
Boolean.class));
String outOfOrder =
testUtilities.rhinoEvaluateConvert("outOfOrderError", String.class);
assertEquals("OutOfOrder", null, outOfOrder);
assertEquals("status 200", Integer.valueOf(200),
@@ -138,4 +135,4 @@ public class JsHttpRequestTest extends
AbstractCXFSpringTest {
URL furl = staticFile.toURI().toURL();
return furl.toString();
}
-}
\ No newline at end of file
+}
diff --git
a/rt/rs/extensions/providers/src/test/java/org/apache/cxf/jaxrs/provider/aegis/AegisElementProviderTest.java
b/rt/rs/extensions/providers/src/test/java/org/apache/cxf/jaxrs/provider/aegis/AegisElementProviderTest.java
index 403a40b..6a2381a 100644
---
a/rt/rs/extensions/providers/src/test/java/org/apache/cxf/jaxrs/provider/aegis/AegisElementProviderTest.java
+++
b/rt/rs/extensions/providers/src/test/java/org/apache/cxf/jaxrs/provider/aegis/AegisElementProviderTest.java
@@ -83,7 +83,7 @@ public class AegisElementProviderTest {
AegisTestBean bean = p.readFrom(AegisTestBean.class, null, null,
null, null, new
ByteArrayInputStream(simpleBytes));
assertEquals("hovercraft", bean.getStrValue());
- assertEquals(Boolean.TRUE, bean.getBoolValue());
+ assertTrue(bean.getBoolValue());
}
@@ -94,7 +94,7 @@ public class AegisElementProviderTest {
AegisTestBean bean = p.readFrom(AegisTestBean.class, null, null,
null, null, new
ByteArrayInputStream(bytes));
assertEquals("hovercraft", bean.getStrValue());
- assertEquals(Boolean.TRUE, bean.getBoolValue());
+ assertTrue(bean.getBoolValue());
}
@Test
@@ -165,10 +165,10 @@ public class AegisElementProviderTest {
Map.Entry<AegisTestBean, AegisSuperBean> entry =
map2.entrySet().iterator().next();
AegisTestBean bean1 = entry.getKey();
assertEquals("hovercraft", bean1.getStrValue());
- assertEquals(Boolean.TRUE, bean1.getBoolValue());
+ assertTrue(bean1.getBoolValue());
AegisTestBean bean22 = entry.getValue();
assertEquals("hovercraft2", bean22.getStrValue());
- assertEquals(Boolean.TRUE, bean22.getBoolValue());
+ assertTrue(bean22.getBoolValue());
}
@@ -179,4 +179,4 @@ public class AegisElementProviderTest {
Map<AegisTestBean, AegisSuperBean> mapFunction();
}
-}
\ No newline at end of file
+}
diff --git
a/rt/rs/security/jose-parent/jose/src/test/java/org/apache/cxf/rs/security/jose/jws/JwsCompactReaderWriterTest.java
b/rt/rs/security/jose-parent/jose/src/test/java/org/apache/cxf/rs/security/jose/jws/JwsCompactReaderWriterTest.java
index ace90cb..2dca7a3 100644
---
a/rt/rs/security/jose-parent/jose/src/test/java/org/apache/cxf/rs/security/jose/jws/JwsCompactReaderWriterTest.java
+++
b/rt/rs/security/jose-parent/jose/src/test/java/org/apache/cxf/rs/security/jose/jws/JwsCompactReaderWriterTest.java
@@ -231,7 +231,7 @@ public class JwsCompactReaderWriterTest {
private void validateSpecClaim(JwtClaims claims) {
assertEquals("joe", claims.getIssuer());
assertEquals(Long.valueOf(1300819380), claims.getExpiryTime());
- assertEquals(Boolean.TRUE,
claims.getClaim("http://example.com/is_root";));
+ assertTrue((Boolean)claims.getClaim("http://example.com/is_root";));
}
@Test
@@ -318,4 +318,4 @@ public class JwsCompactReaderWriterTest {
jsonWriter.setFormat(true);
return jsonWriter;
}
-}
\ No newline at end of file
+}
diff --git
a/rt/transports/http-jetty/src/test/java/org/apache/cxf/transport/http_jetty/spring/ApplicationContextTest.java
b/rt/transports/http-jetty/src/test/java/org/apache/cxf/transport/http_jetty/spring/ApplicationContextTest.java
index d579d89..8cabb33 100644
---
a/rt/transports/http-jetty/src/test/java/org/apache/cxf/transport/http_jetty/spring/ApplicationContextTest.java
+++
b/rt/transports/http-jetty/src/test/java/org/apache/cxf/transport/http_jetty/spring/ApplicationContextTest.java
@@ -162,8 +162,8 @@ public class ApplicationContextTest {
getEndpointInfo("sna", "foo2", "https://localhost:9003";), bus);
engine = (JettyHTTPServerEngine)jd4.getEngine();
-
assertEquals(engine.getTlsServerParameters().getClientAuthentication().isWant(),
false);
-
assertEquals(engine.getTlsServerParameters().getClientAuthentication().isRequired(),
false);
+
assertFalse(engine.getTlsServerParameters().getClientAuthentication().isWant());
+
assertFalse(engine.getTlsServerParameters().getClientAuthentication().isRequired());
JettyHTTPDestination jd5 =
(JettyHTTPDestination)factory.getDestination(
@@ -188,4 +188,4 @@ public class ApplicationContextTest {
}
-}
\ No newline at end of file
+}
diff --git
a/rt/transports/http-netty/netty-server/src/test/java/org/apache/cxf/transport/http/netty/server/spring/ApplicationContextTest.java
b/rt/transports/http-netty/netty-server/src/test/java/org/apache/cxf/transport/http/netty/server/spring/ApplicationContextTest.java
index e028a4c..9a5d835 100644
---
a/rt/transports/http-netty/netty-server/src/test/java/org/apache/cxf/transport/http/netty/server/spring/ApplicationContextTest.java
+++
b/rt/transports/http-netty/netty-server/src/test/java/org/apache/cxf/transport/http/netty/server/spring/ApplicationContextTest.java
@@ -44,6 +44,7 @@ import org.junit.Before;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
@@ -150,8 +151,8 @@ public class ApplicationContextTest {
getEndpointInfo("sna", "foo2", "https://localhost:9003";), bus);
engine = (NettyHttpServerEngine)jd4.getEngine();
-
assertEquals(engine.getTlsServerParameters().getClientAuthentication().isWant(),
false);
-
assertEquals(engine.getTlsServerParameters().getClientAuthentication().isRequired(),
false);
+
assertFalse(engine.getTlsServerParameters().getClientAuthentication().isWant());
+
assertFalse(engine.getTlsServerParameters().getClientAuthentication().isRequired());
/*NettyHttpDestination jd5 =
(NettyHttpDestination)factory.getDestination(
diff --git
a/rt/transports/http-undertow/src/test/java/org/apache/cxf/transport/http_undertow/spring/ApplicationContextTest.java
b/rt/transports/http-undertow/src/test/java/org/apache/cxf/transport/http_undertow/spring/ApplicationContextTest.java
index 1834895..83c752e 100644
---
a/rt/transports/http-undertow/src/test/java/org/apache/cxf/transport/http_undertow/spring/ApplicationContextTest.java
+++
b/rt/transports/http-undertow/src/test/java/org/apache/cxf/transport/http_undertow/spring/ApplicationContextTest.java
@@ -44,6 +44,7 @@ import org.junit.Before;
import org.junit.Test;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
@@ -157,8 +158,8 @@ public class ApplicationContextTest {
getEndpointInfo("sna", "foo2", "https://localhost:9003";), bus);
engine = (UndertowHTTPServerEngine)jd4.getEngine();
-
assertEquals(engine.getTlsServerParameters().getClientAuthentication().isWant(),
false);
-
assertEquals(engine.getTlsServerParameters().getClientAuthentication().isRequired(),
false);
+
assertFalse(engine.getTlsServerParameters().getClientAuthentication().isWant());
+
assertFalse(engine.getTlsServerParameters().getClientAuthentication().isRequired());
UndertowHTTPDestination jd5 =
(UndertowHTTPDestination)factory.getDestination(
@@ -183,4 +184,4 @@ public class ApplicationContextTest {
}
-}
\ No newline at end of file
+}
diff --git
a/rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/uri/JMSEndpointTest.java
b/rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/uri/JMSEndpointTest.java
index 3bd2463..a959de5 100644
---
a/rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/uri/JMSEndpointTest.java
+++
b/rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/uri/JMSEndpointTest.java
@@ -51,7 +51,7 @@ public class JMSEndpointTest {
assertEquals(JMSEndpoint.QUEUE, endpoint.getJmsVariant());
assertEquals(endpoint.getDestinationName(), "Foo.Bar");
assertEquals(endpoint.getJmsVariant(), JMSEndpoint.QUEUE);
- assertEquals(false, endpoint.isUseConduitIdSelector());
+ assertFalse(endpoint.isUseConduitIdSelector());
assertEquals(endpoint.getParameters().size(), 2);
assertEquals(endpoint.getParameter("foo"), "bar");
assertEquals(endpoint.getParameter("foo2"), "bar2");
diff --git
a/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/ClientServerMiscTest.java
b/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/ClientServerMiscTest.java
index ab71cc3..27aa391 100644
---
a/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/ClientServerMiscTest.java
+++
b/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/ClientServerMiscTest.java
@@ -416,7 +416,7 @@ public class ClientServerMiscTest extends
AbstractBusClientServerTestBase {
DocLitWrappedCodeFirstService port = service.getPort(portName,
DocLitWrappedCodeFirstService.class);
Holder<Boolean> created = new Holder<>();
port.singleInOut(created);
- assertEquals(created.value, Boolean.FALSE);
+ assertFalse(created.value);
}
private void setASM(boolean b) throws Exception {
diff --git
a/systests/rs-security/src/test/java/org/apache/cxf/systest/jaxrs/security/oauth2/grants/IntrospectionServiceTest.java
b/systests/rs-security/src/test/java/org/apache/cxf/systest/jaxrs/security/oauth2/grants/IntrospectionServiceTest.java
index 96844dd..cb24660 100644
---
a/systests/rs-security/src/test/java/org/apache/cxf/systest/jaxrs/security/oauth2/grants/IntrospectionServiceTest.java
+++
b/systests/rs-security/src/test/java/org/apache/cxf/systest/jaxrs/security/oauth2/grants/IntrospectionServiceTest.java
@@ -43,6 +43,7 @@ import org.junit.runner.RunWith;
import org.junit.runners.Parameterized.Parameters;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
@@ -232,7 +233,7 @@ public class IntrospectionServiceTest extends
AbstractBusClientServerTestBase {
Response response = client.post(form);
TokenIntrospection tokenIntrospection =
response.readEntity(TokenIntrospection.class);
- assertEquals(tokenIntrospection.isActive(), false);
+ assertFalse(tokenIntrospection.isActive());
}
@org.junit.Test
@@ -295,7 +296,7 @@ public class IntrospectionServiceTest extends
AbstractBusClientServerTestBase {
response = client.post(form);
tokenIntrospection = response.readEntity(TokenIntrospection.class);
- assertEquals(tokenIntrospection.isActive(), false);
+ assertFalse(tokenIntrospection.isActive());
}
@org.junit.Test
diff --git
a/systests/transports/src/test/java/org/apache/cxf/systest/https/conduit/HTTPSConduitTest.java
b/systests/transports/src/test/java/org/apache/cxf/systest/https/conduit/HTTPSConduitTest.java
index 3ff60cb..d7f8af1 100644
---
a/systests/transports/src/test/java/org/apache/cxf/systest/https/conduit/HTTPSConduitTest.java
+++
b/systests/transports/src/test/java/org/apache/cxf/systest/https/conduit/HTTPSConduitTest.java
@@ -324,8 +324,8 @@ public class HTTPSConduitTest extends
AbstractBusClientServerTestBase {
(HTTPConduit) client.getConduit();
HTTPClientPolicy httpClientPolicy = http.getClient();
- assertEquals("the httpClientPolicy's autoRedirect should be true",
- true, httpClientPolicy.isAutoRedirect());
+ assertTrue("the httpClientPolicy's autoRedirect should be true",
+ httpClientPolicy.isAutoRedirect());
TLSClientParameters tlsParameters = http.getTlsClientParameters();
assertNotNull("the http conduit's tlsParameters should not be null",
tlsParameters);
diff --git
a/systests/uncategorized/src/test/java/org/apache/cxf/systest/factory_pattern/ManualHttpMulitplexClientServerTest.java
b/systests/uncategorized/src/test/java/org/apache/cxf/systest/factory_pattern/ManualHttpMulitplexClientServerTest.java
index 7538d59..b17d90a 100644
---
a/systests/uncategorized/src/test/java/org/apache/cxf/systest/factory_pattern/ManualHttpMulitplexClientServerTest.java
+++
b/systests/uncategorized/src/test/java/org/apache/cxf/systest/factory_pattern/ManualHttpMulitplexClientServerTest.java
@@ -47,7 +47,6 @@ import org.apache.cxf.ws.addressing.EndpointReferenceUtils;
import org.junit.BeforeClass;
import org.junit.Test;
-import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
@@ -118,21 +117,21 @@ public class ManualHttpMulitplexClientServerTest extends
AbstractBusClientServer
setupContextWithEprAddress(epr, num);
IsEvenResponse numResp = num.isEven();
- assertEquals("2 is even", Boolean.TRUE, numResp.isEven());
+ assertTrue("2 is even", numResp.isEven());
// try again with the address from another epr
w3cEpr = nfact.create("3");
epr = ProviderImpl.convertToInternal(w3cEpr);
setupContextWithEprAddress(epr, num);
numResp = num.isEven();
- assertEquals("3 is not even", Boolean.FALSE, numResp.isEven());
+ assertFalse("3 is not even", numResp.isEven());
// try again with the address from another epr
w3cEpr = nfact.create("6");
epr = ProviderImpl.convertToInternal(w3cEpr);
setupContextWithEprAddress(epr, num);
numResp = num.isEven();
- assertEquals("6 is even", Boolean.TRUE, numResp.isEven());
+ assertTrue("6 is even", numResp.isEven());
}
@Test
diff --git
a/systests/uncategorized/src/test/java/org/apache/cxf/systest/factory_pattern/MultiplexHttpAddressClientServerTest.java
b/systests/uncategorized/src/test/java/org/apache/cxf/systest/factory_pattern/MultiplexHttpAddressClientServerTest.java
index c2e0f4c..381b75e 100644
---
a/systests/uncategorized/src/test/java/org/apache/cxf/systest/factory_pattern/MultiplexHttpAddressClientServerTest.java
+++
b/systests/uncategorized/src/test/java/org/apache/cxf/systest/factory_pattern/MultiplexHttpAddressClientServerTest.java
@@ -47,7 +47,6 @@ import org.apache.cxf.testutil.common.TestUtil;
import org.junit.BeforeClass;
import org.junit.Test;
-import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertTrue;
@@ -132,7 +131,7 @@ public class MultiplexHttpAddressClientServerTest extends
AbstractBusClientServe
NUMBER_SERVANT_ADDRESS_ROOT + "103");
IsEvenResponse numResp = num.isEven();
- assertEquals("103 is not even", Boolean.FALSE, numResp.isEven());
+ assertFalse("103 is not even", numResp.isEven());
}
@Test
diff --git
a/tools/wsdlto/frontend/jaxws/src/test/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/wsdl11/JAXWSDefinitionBuilderTest.java
b/tools/wsdlto/frontend/jaxws/src/test/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/wsdl11/JAXWSDefinitionBuilderTest.java
index 4ecf9f7..c65ba5e 100644
---
a/tools/wsdlto/frontend/jaxws/src/test/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/wsdl11/JAXWSDefinitionBuilderTest.java
+++
b/tools/wsdlto/frontend/jaxws/src/test/java/org/apache/cxf/tools/wsdlto/frontend/jaxws/wsdl11/JAXWSDefinitionBuilderTest.java
@@ -75,7 +75,7 @@ public class JAXWSDefinitionBuilderTest {
List<?> portTypeList = portType.getExtensibilityElements();
JAXWSBinding binding = (JAXWSBinding)portTypeList.get(0);
- assertEquals("Customized enable EnableWrapperStyle name does not been
parsered", true, binding
+ assertTrue("Customized enable EnableWrapperStyle name does not been
parsered", binding
.isEnableWrapperStyle());
List<?> opList = portType.getOperations();
@@ -123,7 +123,7 @@ public class JAXWSDefinitionBuilderTest {
List<?> portTypeList = portType.getExtensibilityElements();
JAXWSBinding binding = (JAXWSBinding)portTypeList.get(0);
- assertEquals("Customized enable EnableWrapperStyle name does not been
parsered", true, binding
+ assertTrue("Customized enable EnableWrapperStyle name does not been
parsered", binding
.isEnableWrapperStyle());
List<?> opList = portType.getOperations();
