[cxf] 02/02: cxf-rt-ws-addr: fix PMD rule: UnusedAssignment

[buhhunyx]

This is an automated email from the ASF dual-hosted git repository.

buhhunyx pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cxf.git

commit b341f7cd05a5130f53efd56c01d14136655afe35
Author: Alexey Markevich <buhhu...@gmail.com>
AuthorDate: Mon Mar 15 20:25:33 2021 +0300

    cxf-rt-ws-addr: fix PMD rule: UnusedAssignment
---
 .../java/org/apache/cxf/ws/addressing/impl/InternalContextUtils.java   | 2 +-
 .../main/java/org/apache/cxf/ws/addressing/impl/MAPAggregatorImpl.java | 3 +--
 .../addr/src/main/java/org/apache/cxf/ws/addressing/soap/MAPCodec.java | 3 +--
 .../src/test/java/org/apache/cxf/ws/addressing/soap/MAPCodecTest.java  | 2 +-
 4 files changed, 4 insertions(+), 6 deletions(-)

diff --git 
a/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/impl/InternalContextUtils.java
 
b/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/impl/InternalContextUtils.java
index 8c46dac..6182ef0 100644
--- 
a/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/impl/InternalContextUtils.java
+++ 
b/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/impl/InternalContextUtils.java
@@ -375,7 +375,7 @@ final class InternalContextUtils {
      * @return the Action URI
      */
     public static AttributedURIType getAction(Message message) {
-        String action = null;
+        final String action;
         LOG.fine("Determining action");
         Exception fault = message.getContent(Exception.class);
 
diff --git 
a/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/impl/MAPAggregatorImpl.java
 
b/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/impl/MAPAggregatorImpl.java
index d6f8278..a1f442a 100644
--- 
a/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/impl/MAPAggregatorImpl.java
+++ 
b/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/impl/MAPAggregatorImpl.java
@@ -1061,8 +1061,7 @@ public class MAPAggregatorImpl extends MAPAggregator {
                                              boolean isProviderContext,
                                              boolean isOutbound) {
 
-        AddressingProperties maps = null;
-        maps = ContextUtils.retrieveMAPs(message,
+        AddressingProperties maps = ContextUtils.retrieveMAPs(message,
                                          isProviderContext,
                                          isOutbound);
         LOG.log(Level.FINE, "MAPs retrieved from message {0}", maps);
diff --git 
a/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/soap/MAPCodec.java 
b/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/soap/MAPCodec.java
index eccbaf1..e605609 100644
--- a/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/soap/MAPCodec.java
+++ b/rt/ws/addr/src/main/java/org/apache/cxf/ws/addressing/soap/MAPCodec.java
@@ -386,13 +386,12 @@ public class MAPCodec extends AbstractSoapInterceptor {
                         if (header == null) {
                             header = 
getHeaderFactory().getHeader(msg.getVersion());
                         }
-                        JAXBElement<?> jaxbEl = null;
                         if (o instanceof Element) {
                             Element e = (Element)o;
                             Node importedNode = 
header.getOwnerDocument().importNode(e, true);
                             header.appendChild(importedNode);
                         } else {
-                            jaxbEl = (JAXBElement<?>) o;
+                            JAXBElement<?> jaxbEl = (JAXBElement<?>) o;
                             ctx.createMarshaller().marshal(jaxbEl, header);
                         }
 
diff --git 
a/rt/ws/addr/src/test/java/org/apache/cxf/ws/addressing/soap/MAPCodecTest.java 
b/rt/ws/addr/src/test/java/org/apache/cxf/ws/addressing/soap/MAPCodecTest.java
index 760e27d..b30fbf6 100644
--- 
a/rt/ws/addr/src/test/java/org/apache/cxf/ws/addressing/soap/MAPCodecTest.java
+++ 
b/rt/ws/addr/src/test/java/org/apache/cxf/ws/addressing/soap/MAPCodecTest.java
@@ -612,7 +612,7 @@ public class MAPCodecTest {
     }
 
     private boolean isReply(boolean exposedAsNative) {
-        boolean isReply = false;
+        final boolean isReply;
         if (exposedAsNative) {
             isReply =
                 Names.WSA_RELATIONSHIP_REPLY.equals(