mbeckerle commented on issue #323: WIP: Configure Sonarcloud.io URL: https://github.com/apache/incubator-daffodil/pull/323#issuecomment-584824391 The number of code smells: 800-ish, doesn't seem unreasonable to me. I looked at them, and while I don't see them as major flaws anywhere, they do seem like real coding-style complaints where we are not following naming conventions, or not following guidlines to document empty classes, etc. It's always best if you have this sort of tool and you set a policy of "no messages" from it. I.e., just like for the scala compiler where we have a no-warnings policy. These code-smells can all be fixed quite quickly. Yes there are 800 of them, so even at 30 seconds per that's a day of work. But since misery loves company, I'd suggest we all get in a room, race to fix them, and when they're all done, whoever fixed the most gets free lunch or something.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
