[ 
https://issues.apache.org/jira/browse/DAFFODIL-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046873#comment-17046873
 ] 

Olabusayo Kilo commented on DAFFODIL-2275:
------------------------------------------

TODOs:

* Fix projectKey typo
* Update confirmations from test instance to reflect in main instance
* Look into test classes name convention rule
* Look into Java classes with test in the name
* Investigate empty methods; adding comments as necessary
* Increase Cognitive complexity rule threshold to 100
* Create bugs for regex string duplications and turn rule off
* Update convention for constant names to be upper camel case (incl enums and 
obj)
* Look into commented out code: if no comment on why, remove. If commented, 
look into structured comment that can be added so it's ignored
* For XML of comment out code: mark ./apache/daffodil/xsd/XMLSchem issues as 
Won't fix
* Turn off rule for collapsible ifs
* There is a ticket for FIXME/TODO rules; go through list and confirm
* Create bug to look into and fix all unused function params
* Mark all "function param count is too large" issues as won't fix
* Create bug report for duplicated code blocks
* Remove "Match case count too large rule" and mark current as false positive 
if needed
* Try turning on sbt unused and see how many warnings we get
* Investigate unused private functions / create bug report as necessary
* Add comments for empty code block
* Update method name to match scala convention; add something in particular for 
test cases ("test_" prefix) rather than just arbitrarily allowing underscores
* Mark current boolean literal issues as "Won't Fix"
* Update local var/para's naming convention to match Scala's naming convention
* Investigate unused local params; might need bug report
* Fix out of order modifiers on functions
* Fix != operator issue

> Configure Daffodil to use Sonarqube/Sonarcloud.io
> -------------------------------------------------
>
>                 Key: DAFFODIL-2275
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2275
>             Project: Daffodil
>          Issue Type: Improvement
>          Components: Infrastructure
>            Reporter: Olabusayo Kilo
>            Assignee: Olabusayo Kilo
>            Priority: Major
>             Fix For: 2.6.0
>
>
> We want to integrate Sonarqube into our development workflow, using Github 
> Actions. We're awaiting creation on Apache's Sonarcloud.io 
> https://issues.apache.org/jira/browse/INFRA-19812 , after which, we can 
> proceed with configuring Github Actions to add this functionality.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to