stevedlawrence commented on a change in pull request #326: Daffodil 2280
cleanup - removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393664387
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala
##########
@@ -64,11 +64,25 @@ trait SchemaComponent
override def oolagContextViaArgs = optLexicalParent
+ /**
+ * Override and call super.check() to indicate
+ * things that need to be checked if the object is being used, that is.
+ */
+ protected def check(): Unit = {
Review comment:
This looks like a new pattern for doing checks. How is this different from
just requiredEvaluations, and why does requiredEvaluations still need to be
done inside this check function? It's not clear to me how those are different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
