mbeckerle commented on a change in pull request #326: Daffodil 2280 cleanup -
removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393739987
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##########
@@ -288,7 +291,10 @@ trait ElementBase
}
}
- private lazy val parentMinimizedScope = enclosingElement.map {
_.minimizedScope }.getOrElse(scala.xml.TopScope)
+ private lazy val parentMinimizedScope = {
+ val ee = enclosingElements.headOption // FIXME: doesn't work unless all
are same.
Review comment:
Ah. I have not dealt with the minimized scope issue as yet. That remains a
TODO/FIXME issue here.
This is assuming the right answer for parentMinimizedScope is that of the
first shared instance. Because we only share things that share properties
(shared PropEnv), this works in most cases. Not clear it will for this scope
minimizaiton stuff because that's not really about properties. So this will
need fixing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
