mbeckerle commented on a change in pull request #326: Daffodil 2280 cleanup -
removes backpointers and factory patterns no longer needed
URL: https://github.com/apache/incubator-daffodil/pull/326#discussion_r393765782
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/SchemaComponent.scala
##########
@@ -121,7 +135,7 @@ trait SchemaComponent
def isHidden: Boolean = isHiddenLV
private lazy val isHiddenLV = {
- val optEC = enclosingComponent
+ val optEC = enclosingTerms.headOption // FIXME: broken if there are hidden
and non-hidden uses
Review comment:
Yup. I'm not messing with isHidden stuff in this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
