[
https://issues.apache.org/jira/browse/DAFFODIL-2296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063455#comment-17063455
]
Steve Lawrence commented on DAFFODIL-2296:
------------------------------------------
Actually, on second thought, I'm not sure Lola's changes will fix this. I think
the issue here is that the new logic for finding the default branch first looks
for am empty branch (i.e. <sequence />) and if that does not exist, it will
search for a fully defaultable branch. This behave is different that before, in
that we used to just find the first empty OR defaultable branch.
So one question, is this the correct behavior? What is the correct behavior for
unparsing choices when all branches are optional? Does an empty sequence have
preference over defaultable?
Now, I think the real issue is that the empty sequence can result in a
NadaUnparser. So there must be some special logic for if the defaultable branch
(no matter how it is determined) results in a NadaUnparser, we just don't
unparse anything. I don't think change will be part of Lola's work.
> NACHA failing some tests with "Abort: NadaUnparsers are all supposed to
> optimize out"
> -------------------------------------------------------------------------------------
>
> Key: DAFFODIL-2296
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2296
> Project: Daffodil
> Issue Type: Bug
> Components: Middle "End"
> Affects Versions: 2.5.0
> Reporter: Mike Beckerle
> Assignee: Mike Beckerle
> Priority: Major
> Fix For: 2.6.0
>
>
> On the 2.6.0 development branch, git hash:
> 356291c3f5cbd82832bc68f7f573b292a46feb3d
> These two NACHA tests fail. NACHA is a DFDL schema published on github that
> is portable to Daffodil and IBM DFDL.
> TestNACHA.test_ppd_valid_1
> TestNACHA.test_ccd_valid_1
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
