olabusayoT commented on a change in pull request #366:
URL: https://github.com/apache/incubator-daffodil/pull/366#discussion_r413012854
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/RuntimeData.scala
##########
@@ -993,22 +912,22 @@ final class ChoiceRuntimeData(
* hook these objects into a parent-child tree without
Review comment:
is this supposed to be fixed w/i this PR?
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/runtime1/SchemaSetRuntime1Mixin.scala
##########
@@ -34,10 +34,10 @@ import org.apache.daffodil.util.LogLevel
trait SchemaSetRuntime1Mixin { self : SchemaSet =>
- requiredEvaluationsAlways(variableMap)
+ // requiredEvaluationsAlways(variableMap)
Review comment:
With the efforts from the Sonarcloud clean ups, I'd rather we delete. If
we need it we can add it back
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/runtime1/SchemaSetRuntime1Mixin.scala
##########
@@ -34,10 +34,10 @@ import org.apache.daffodil.util.LogLevel
trait SchemaSetRuntime1Mixin { self : SchemaSet =>
- requiredEvaluationsAlways(variableMap)
+ // requiredEvaluationsAlways(variableMap)
requiredEvaluationsAlways(parser)
requiredEvaluationsAlways(unparser)
- requiredEvaluationsAlways(root.runtimeData)
+ // requiredEvaluationsAlways(root.runtimeData)
Review comment:
Same as above
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/TermEncodingMixin.scala
##########
@@ -31,7 +31,7 @@ import org.apache.daffodil.schema.annotation.props.gen.YesNo
*/
trait TermEncodingMixin extends KnownEncodingMixin { self: Term =>
- requiredEvaluationsAlways(encodingInfo.preSerialization)
+ // requiredEvaluationsAlways(encodingInfo.preSerialization)
Review comment:
same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
