This is an automated email from the ASF dual-hosted git repository.
olabusayo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-daffodil.git
The following commit(s) were added to refs/heads/master by this push:
new 075ed01 Sonarcloud Updates
075ed01 is described below
commit 075ed018d786d332deddc5e20169939f95470fef
Author: olabusayoT <[email protected]>
AuthorDate: Tue Apr 14 14:51:24 2020 -0400
Sonarcloud Updates
-- add comment within empty methods
DAFFODIL-2275
---
.../src/main/scala/org/apache/daffodil/Main.scala | 24 +++++--
.../daffodil/io/LimitingJavaIinputStreams.scala | 3 +-
.../processors/charset/BitsCharsetDecoder.scala | 8 ++-
.../apache/daffodil/japi/debugger/Debugger.scala | 12 +++-
.../org/apache/daffodil/japi/logger/Logger.scala | 12 +++-
.../daffodil/japi/packageprivate/Utils.scala | 4 +-
.../apache/daffodil/cookers/EntityReplacer.scala | 16 +++--
.../apache/daffodil/xml/DaffodilXMLLoader.scala | 20 ++++--
.../unparsers/ChoiceAndOtherVariousUnparsers.scala | 4 +-
.../processors/unparsers/ElementUnparser.scala | 4 +-
.../daffodil/debugger/TraceDebuggerRunner.scala | 8 ++-
.../scala/org/apache/daffodil/dpath/DState.scala | 8 ++-
.../apache/daffodil/events/ParseEventHandler.scala | 80 ++++++++++++++++------
.../daffodil/infoset/NullInfosetOutputter.scala | 4 +-
.../apache/daffodil/processors/DFDLDelimiter.scala | 4 +-
.../daffodil/processors/ProcessorStateBases.scala | 8 ++-
.../processors/parsers/ElementKindParsers.scala | 4 +-
.../daffodil/processors/unparsers/UState.scala | 4 +-
.../apache/daffodil/sapi/debugger/Debugger.scala | 12 +++-
.../org/apache/daffodil/sapi/logger/Logger.scala | 12 +++-
.../daffodil/sapi/packageprivate/Utils.scala | 4 +-
21 files changed, 191 insertions(+), 64 deletions(-)
diff --git a/daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
b/daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
index 02155c2..13e715d 100644
--- a/daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
+++ b/daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
@@ -105,11 +105,21 @@ import
org.apache.daffodil.schema.annotation.props.gen.BitOrder
import org.apache.daffodil.udf.UserDefinedFunctionFatalErrorException
class NullOutputStream extends OutputStream {
- override def close() {}
- override def flush() {}
- override def write(b: Array[Byte]) {}
- override def write(b: Array[Byte], off: Int, len: Int) {}
- override def write(b: Int) {}
+ override def close(): Unit = {
+ //do nothing
+ }
+ override def flush(): Unit = {
+ //do nothing
+ }
+ override def write(b: Array[Byte]): Unit = {
+ //do nothing
+ }
+ override def write(b: Array[Byte], off: Int, len: Int): Unit = {
+ //do nothing
+ }
+ override def write(b: Int): Unit = {
+ //do nothing
+ }
}
class CommandLineXMLLoaderErrorHandler() extends org.xml.sax.ErrorHandler with
Logging {
@@ -1015,7 +1025,9 @@ object Main extends Logging {
threadPool.submit(runnable)
}
- def reportFailure(t: Throwable) {}
+ def reportFailure(t: Throwable): Unit = {
+ //do nothing
+ }
}
val nullChannelForUnparse =
java.nio.channels.Channels.newChannel(new NullOutputStream)
diff --git
a/daffodil-io/src/main/scala/org/apache/daffodil/io/LimitingJavaIinputStreams.scala
b/daffodil-io/src/main/scala/org/apache/daffodil/io/LimitingJavaIinputStreams.scala
index a169a48..c34dc72 100644
---
a/daffodil-io/src/main/scala/org/apache/daffodil/io/LimitingJavaIinputStreams.scala
+++
b/daffodil-io/src/main/scala/org/apache/daffodil/io/LimitingJavaIinputStreams.scala
@@ -209,7 +209,8 @@ class RegexLimitingStream(inputStream: InputStream,
override def available(): Int =
if (charsIter.hasNext) 1 else 0
- override def close() {
+ override def close(): Unit = {
+ //do nothing
}
private var noMoreChunks = false
diff --git
a/daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsCharsetDecoder.scala
b/daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsCharsetDecoder.scala
index a03225e..8ebb86a 100644
---
a/daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsCharsetDecoder.scala
+++
b/daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsCharsetDecoder.scala
@@ -142,7 +142,9 @@ abstract class BitsCharsetDecoderByteSize
}
}
- override def reset(): Unit = {}
+ override def reset(): Unit = {
+ //do nothing
+ }
}
@@ -194,5 +196,7 @@ final class BitsCharsetNonByteSizeDecoder(charset:
BitsCharsetNonByteSize)
charset.codeToChar(code)
}
- override def reset(): Unit = {}
+ override def reset(): Unit = {
+ //do nothing
+ }
}
diff --git
a/daffodil-japi/src/main/scala/org/apache/daffodil/japi/debugger/Debugger.scala
b/daffodil-japi/src/main/scala/org/apache/daffodil/japi/debugger/Debugger.scala
index 9cc2d3d..e0ba7ae 100644
---
a/daffodil-japi/src/main/scala/org/apache/daffodil/japi/debugger/Debugger.scala
+++
b/daffodil-japi/src/main/scala/org/apache/daffodil/japi/debugger/Debugger.scala
@@ -66,9 +66,15 @@ abstract class DebuggerRunner {
* [[DebuggerRunner]] that writes verbose information about parsing to stdout
*/
final class TraceDebuggerRunner extends DebuggerRunner {
- def init(): Unit = {}
+ def init(): Unit = {
+ //do nothing
+ }
def getCommand(): String = ""
- def lineOutput(line: String) = {}
- def fini(): Unit = {}
+ def lineOutput(line: String) = {
+ //do nothing
+ }
+ def fini(): Unit = {
+ //do nothing
+ }
}
diff --git
a/daffodil-japi/src/main/scala/org/apache/daffodil/japi/logger/Logger.scala
b/daffodil-japi/src/main/scala/org/apache/daffodil/japi/logger/Logger.scala
index 00d84c0..09d7940 100644
--- a/daffodil-japi/src/main/scala/org/apache/daffodil/japi/logger/Logger.scala
+++ b/daffodil-japi/src/main/scala/org/apache/daffodil/japi/logger/Logger.scala
@@ -96,14 +96,18 @@ abstract class LogWriter {
* [[LogWriter]] that writes log messages to stdout
*/
final class ConsoleLogWriter extends LogWriter {
- protected def write(level: LogLevel, logID: String, msg: String): Unit = {}
+ protected def write(level: LogLevel, logID: String, msg: String): Unit = {
+ //do nothing
+ }
}
/**
* [[LogWriter]] that drops all log messages
*/
final class NullLogWriter extends LogWriter {
- protected def write(level: LogLevel, logID: String, msg: String): Unit = {}
+ protected def write(level: LogLevel, logID: String, msg: String): Unit = {
+ //do nothing
+ }
}
/**
@@ -118,5 +122,7 @@ final class FileLogWriter(file: File) extends LogWriter {
* @return the file the log writer writes to
*/
def getFile = file
- protected def write(level: LogLevel, logID: String, msg: String): Unit = {}
+ protected def write(level: LogLevel, logID: String, msg: String): Unit = {
+ //do nothing
+ }
}
diff --git
a/daffodil-japi/src/main/scala/org/apache/daffodil/japi/packageprivate/Utils.scala
b/daffodil-japi/src/main/scala/org/apache/daffodil/japi/packageprivate/Utils.scala
index 0d0c1a9..1f48569 100644
---
a/daffodil-japi/src/main/scala/org/apache/daffodil/japi/packageprivate/Utils.scala
+++
b/daffodil-japi/src/main/scala/org/apache/daffodil/japi/packageprivate/Utils.scala
@@ -93,7 +93,9 @@ private[japi] object ValidationConversions {
private[japi] class JavaLogWriter(logWriter: LogWriter)
extends SLogWriter {
- protected def write(msg: String): Unit = {}
+ protected def write(msg: String): Unit = {
+ //do nothing
+ }
override def log(lvl: SLogLevel.Type, logID: String, msg: String, args:
Seq[Any]) {
if (logWriter != null) {
diff --git
a/daffodil-lib/src/main/scala/org/apache/daffodil/cookers/EntityReplacer.scala
b/daffodil-lib/src/main/scala/org/apache/daffodil/cookers/EntityReplacer.scala
index 80ed58d..41714fc 100644
---
a/daffodil-lib/src/main/scala/org/apache/daffodil/cookers/EntityReplacer.scala
+++
b/daffodil-lib/src/main/scala/org/apache/daffodil/cookers/EntityReplacer.scala
@@ -528,9 +528,15 @@ sealed abstract class StringLiteralBase(propNameArg:
String,
cooked
}
- protected def testRaw(raw: String, context: ThrowsSDE): Unit = {}
- protected def testThawed(thawed: String, context: ThrowsSDE): Unit = {}
- protected def testCooked(cooked: String, context: ThrowsSDE): Unit = {}
+ protected def testRaw(raw: String, context: ThrowsSDE): Unit = {
+ //do nothing
+ }
+ protected def testThawed(thawed: String, context: ThrowsSDE): Unit = {
+ //do nothing
+ }
+ protected def testCooked(cooked: String, context: ThrowsSDE): Unit = {
+ //do nothing
+ }
}
class StringLiteral(pn: String, allowByteEntities: Boolean)
@@ -671,7 +677,9 @@ sealed abstract class ListOfStringLiteralBase(propNameArg:
String,
protected def oneLiteralCooker: StringLiteralBase
- protected def testCooked(cooked: List[String], context: ThrowsSDE): Unit = {}
+ protected def testCooked(cooked: List[String], context: ThrowsSDE): Unit = {
+ //do nothing
+ }
}
sealed trait ListOfSingleCharacterMixin { self: ListOfStringLiteralBase =>
diff --git
a/daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala
b/daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala
index 3c27ade..ac0dd0f 100644
---
a/daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala
+++
b/daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala
@@ -338,11 +338,21 @@ class InputStreamLSInput(var pubId: String, var sysId:
String, inputStream: Inpu
def getEncoding = null
def getStringData = null
- def setByteStream(byteStream: InputStream) = {}
- def setCertifiedText(certifiedText: Boolean) = {}
- def setCharacterStream(characterStream: Reader) = {}
- def setEncoding(encoding: String) = {}
- def setStringData(stringData: String) = {}
+ def setByteStream(byteStream: InputStream) = {
+ //do nothing
+ }
+ def setCertifiedText(certifiedText: Boolean) = {
+ //do nothing
+ }
+ def setCharacterStream(characterStream: Reader) = {
+ //do nothing
+ }
+ def setEncoding(encoding: String) = {
+ //do nothing
+ }
+ def setStringData(stringData: String) = {
+ //do nothing
+ }
}
/**
diff --git
a/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ChoiceAndOtherVariousUnparsers.scala
b/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ChoiceAndOtherVariousUnparsers.scala
index 6d18562..a94368e 100644
---
a/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ChoiceAndOtherVariousUnparsers.scala
+++
b/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ChoiceAndOtherVariousUnparsers.scala
@@ -79,7 +79,9 @@ class ChoiceBranchEmptyUnparser(val context: RuntimeData)
override lazy val runtimeDependencies = Vector()
- def unparse(state: UState): Unit = {}
+ def unparse(state: UState): Unit = {
+ //do nothing
+ }
}
class ChoiceCombinatorUnparser(
diff --git
a/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ElementUnparser.scala
b/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ElementUnparser.scala
index 06072c8..721f72d 100644
---
a/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ElementUnparser.scala
+++
b/daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ElementUnparser.scala
@@ -485,7 +485,9 @@ sealed trait RegularElementUnparserStartEndStrategy
}
}
- final override protected def captureRuntimeValuedExpressionValues(ustate:
UState): Unit = {}
+ final override protected def captureRuntimeValuedExpressionValues(ustate:
UState): Unit = {
+ //do nothing
+ }
}
diff --git
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/TraceDebuggerRunner.scala
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/TraceDebuggerRunner.scala
index cbc432e..0e30a4c 100644
---
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/TraceDebuggerRunner.scala
+++
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/debugger/TraceDebuggerRunner.scala
@@ -27,7 +27,9 @@ class TraceDebuggerRunner extends InteractiveDebuggerRunner {
"display info diff",
"trace").iterator
- def init(id: InteractiveDebugger): Unit = {}
+ def init(id: InteractiveDebugger): Unit = {
+ //do nothing
+ }
def getCommand: String = {
if (traceIter.hasNext) {
@@ -45,5 +47,7 @@ class TraceDebuggerRunner extends InteractiveDebuggerRunner {
println(line)
}
- def fini(): Unit = {}
+ def fini(): Unit = {
+ //do nothing
+ }
}
diff --git
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DState.scala
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DState.scala
index bbd4e03..320a511 100644
--- a/daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DState.scala
+++ b/daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/DState.scala
@@ -414,8 +414,12 @@ case class DState(
// exist at constant fold time. But we don't want fn:exists to say the result
// is always a constant (false) because at constant folding time, hey,
nothing
// exists... this hook lets us change behavior for constant folding to throw.
- def selfMove(): Unit = {}
- def fnExists(): Unit = {}
+ def selfMove(): Unit = {
+ //do nothing
+ }
+ def fnExists(): Unit = {
+ //do nothing
+ }
// @inline // TODO: Performance maybe this won't allocate a closure if this
is inline? If not replace with macro
final def withRetryIfBlocking[T](body: => T): T =
diff --git
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/events/ParseEventHandler.scala
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/events/ParseEventHandler.scala
index 8f42e1f..b0b5b82 100644
---
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/events/ParseEventHandler.scala
+++
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/events/ParseEventHandler.scala
@@ -34,48 +34,88 @@ trait EventHandler {
/**
* Parser Events
*/
- def init(processor: Parser) {}
+ def init(processor: Parser): Unit = {
+ //do nothing
+ }
- def before(state: PState, processor: Parser) {}
+ def before(state: PState, processor: Parser): Unit = {
+ //do nothing
+ }
- def after(after: PState, processor: Parser) {}
+ def after(after: PState, processor: Parser): Unit = {
+ //do nothing
+ }
- def beforeRepetition(state: PState, processor: Parser) {}
+ def beforeRepetition(state: PState, processor: Parser): Unit = {
+ //do nothing
+ }
- def afterRepetition(after: PState, processor: Parser) {}
+ def afterRepetition(after: PState, processor: Parser): Unit = {
+ //do nothing
+ }
- def startElement(state: PState, processor: Parser) {}
+ def startElement(state: PState, processor: Parser): Unit = {
+ //do nothing
+ }
- def endElement(state: PState, processor: Parser) {}
+ def endElement(state: PState, processor: Parser): Unit = {
+ //do nothing
+ }
- def startArray(state: PState, processor: Parser) {}
+ def startArray(state: PState, processor: Parser): Unit = {
+ //do nothing
+ }
- def endArray(state: PState, processor: Parser) {}
+ def endArray(state: PState, processor: Parser): Unit = {
+ //do nothing
+ }
- def fini(processor: Parser) {}
+ def fini(processor: Parser): Unit = {
+ //do nothing
+ }
/**
* Unparser Events
*/
- def init(processor: Unparser) {}
+ def init(processor: Unparser): Unit = {
+ //do nothing
+ }
- def before(state: UState, processor: Unparser) {}
+ def before(state: UState, processor: Unparser): Unit = {
+ //do nothing
+ }
- def after(after: UState, processor: Unparser) {}
+ def after(after: UState, processor: Unparser): Unit = {
+ //do nothing
+ }
- def beforeRepetition(state: UState, processor: Unparser) {}
+ def beforeRepetition(state: UState, processor: Unparser): Unit = {
+ //do nothing
+ }
- def afterRepetition(after: UState, processor: Unparser) {}
+ def afterRepetition(after: UState, processor: Unparser): Unit = {
+ //do nothing
+ }
- def startElement(state: UState, processor: Unparser) {}
+ def startElement(state: UState, processor: Unparser): Unit = {
+ //do nothing
+ }
- def endElement(state: UState, processor: Unparser) {}
+ def endElement(state: UState, processor: Unparser): Unit = {
+ //do nothing
+ }
- def startArray(state: UState, processor: Unparser) {}
+ def startArray(state: UState, processor: Unparser): Unit = {
+ //do nothing
+ }
- def endArray(state: UState, processor: Unparser) {}
+ def endArray(state: UState, processor: Unparser): Unit = {
+ //do nothing
+ }
- def fini(processor: Unparser) {}
+ def fini(processor: Unparser): Unit = {
+ //do nothing
+ }
}
/**
diff --git
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/NullInfosetOutputter.scala
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/NullInfosetOutputter.scala
index f95d9eb..266b6f0 100644
---
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/NullInfosetOutputter.scala
+++
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/NullInfosetOutputter.scala
@@ -23,7 +23,9 @@ package org.apache.daffodil.infoset
*/
class NullInfosetOutputter() extends InfosetOutputter {
- override def reset(): Unit = {}
+ override def reset(): Unit = {
+ //do nothing
+ }
override def startSimple(simple: DISimple): Boolean = true
override def endSimple(simple: DISimple): Boolean = true
diff --git
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DFDLDelimiter.scala
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DFDLDelimiter.scala
index 88104c5..2c9fcc6 100644
---
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DFDLDelimiter.scala
+++
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DFDLDelimiter.scala
@@ -635,7 +635,9 @@ class WSPStarDelim extends WSPBase with WSP {
class ESDelim extends DelimBase {
override def checkMatch(charIn: Char): Boolean = Assert.impossible("We
should never ask if a character matches an %ES;")
override def allChars: Seq[Char] = Seq.empty
- override def print: Unit = {}
+ override def print: Unit = {
+ //do nothing
+ }
override def printStr: String = typeName
override def typeName: String = "ES"
override def unparseValue(outputNewLine: String): String = ""
diff --git
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorStateBases.scala
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorStateBases.scala
index 2e226e4..1760d35 100644
---
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorStateBases.scala
+++
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessorStateBases.scala
@@ -576,7 +576,9 @@ final class CompileState(tci: DPathCompileInfo,
maybeDataProc: Maybe[DataProcess
def currentNode = Maybe(infoset.asInstanceOf[DINode])
- def notifyDebugging(flag: Boolean): Unit = {}
+ def notifyDebugging(flag: Boolean): Unit = {
+ //do nothing
+ }
private val occursBoundsStack_ = MStackOfLong()
def thisElement = infoset
@@ -584,7 +586,9 @@ final class CompileState(tci: DPathCompileInfo,
maybeDataProc: Maybe[DataProcess
// Members declared in org.apache.daffodil.processors.StateForDebugger
def currentLocation: DataLocation = Assert.usageError("Not to be used.")
- protected def checkBitOrder(): Unit = {}
+ protected def checkBitOrder(): Unit = {
+ //do nothing
+ }
def regexMatchBuffer: CharBuffer = Assert.usageError("Not to be used.")
def regexMatchBitPositionBuffer: LongBuffer = Assert.usageError("Not to be
used.")
diff --git
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementKindParsers.scala
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementKindParsers.scala
index f54c0af..e32828c 100644
---
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementKindParsers.scala
+++
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ElementKindParsers.scala
@@ -131,7 +131,9 @@ class ChoiceBranchEmptyParser(val context: RuntimeData)
override lazy val runtimeDependencies = Vector()
- def parse(state: PState): Unit = {}
+ def parse(state: PState): Unit = {
+ //do nothing
+ }
}
/*
diff --git
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/unparsers/UState.scala
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/unparsers/UState.scala
index 61627dc..8e6d1cd 100644
---
a/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/unparsers/UState.scala
+++
b/daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/unparsers/UState.scala
@@ -384,7 +384,9 @@ final class UStateForSuspension(
override def advanceAccessor: InfosetAccessor = die
override def inspect: Boolean = die
override def inspectAccessor: InfosetAccessor = die
- override def fini: Unit = {}
+ override def fini: Unit = {
+ //do nothing
+ }
override def inspectOrError = die
override def advanceOrError = die
override def isInspectArrayEnd = die
diff --git
a/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/debugger/Debugger.scala
b/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/debugger/Debugger.scala
index b07f4c9..f58d7b3 100644
---
a/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/debugger/Debugger.scala
+++
b/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/debugger/Debugger.scala
@@ -66,9 +66,15 @@ abstract class DebuggerRunner {
* [[DebuggerRunner]] that writes verbose information about parsing to stdout
*/
final class TraceDebuggerRunner extends DebuggerRunner {
- def init(): Unit = {}
+ def init(): Unit = {
+ //do nothing
+ }
def getCommand(): String = ""
- def lineOutput(line: String) = {}
- def fini(): Unit = {}
+ def lineOutput(line: String) = {
+ //do nothing
+ }
+ def fini(): Unit = {
+ //do nothing
+ }
}
diff --git
a/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/logger/Logger.scala
b/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/logger/Logger.scala
index a53edec..e435431 100644
--- a/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/logger/Logger.scala
+++ b/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/logger/Logger.scala
@@ -115,14 +115,18 @@ abstract class LogWriter {
* [[LogWriter]] that writes log messages to stdout
*/
final class ConsoleLogWriter extends LogWriter {
- protected def write(level: LogLevel.Value, logID: String, msg: String): Unit
= {}
+ protected def write(level: LogLevel.Value, logID: String, msg: String): Unit
= {
+ //do nothing
+ }
}
/**
* [[LogWriter]] that drops all log messages
*/
final class NullLogWriter extends LogWriter {
- protected def write(level: LogLevel.Value, logID: String, msg: String): Unit
= {}
+ protected def write(level: LogLevel.Value, logID: String, msg: String): Unit
= {
+ //do nothing
+ }
}
/**
@@ -135,5 +139,7 @@ final class FileLogWriter(file: File) extends LogWriter {
* Retrieve the file the log writer writes to
*/
def getFile = file
- protected def write(level: LogLevel.Value, logID: String, msg: String): Unit
= {}
+ protected def write(level: LogLevel.Value, logID: String, msg: String): Unit
= {
+ //do nothing
+ }
}
diff --git
a/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/packageprivate/Utils.scala
b/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/packageprivate/Utils.scala
index 405a2b1..684a9b0 100644
---
a/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/packageprivate/Utils.scala
+++
b/daffodil-sapi/src/main/scala/org/apache/daffodil/sapi/packageprivate/Utils.scala
@@ -91,7 +91,9 @@ private[sapi] object ValidationConversions {
private[sapi] class JavaLogWriter(logWriter: LogWriter)
extends SLogWriter {
- protected def write(msg: String): Unit = {}
+ protected def write(msg: String): Unit = {
+ //do nothing
+ }
override def log(lvl: SLogLevel.Type, logID: String, msg: String, args:
Seq[Any]) {
if (logWriter != null) {
