andrewjc2000 commented on a change in pull request #394:
URL: https://github.com/apache/incubator-daffodil/pull/394#discussion_r455986288



##########
File path: daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala
##########
@@ -373,6 +374,12 @@ class ProcessorFactory private[japi] (private var pf: 
SProcessorFactory)
     new DataProcessor(dp)
   }
 
+  /**
+   * Exposes the RootView object corresponding to this ProcessorFactory.  This 
can
+   * be used to start a walk using the walkFromRoot method in a DSOM Walker.
+   */
+  def rootView: RootView = pf.rootView

Review comment:
       While this solution is great and simple for Scala, it doesn't seem to 
translate well to Java; `pf.experimental.rootView()` does not compile, and 
IntelliJ thinks that `ProcessorFactory.experimental$.MODULE$.rootView()` 
compiles but this does not work when you go to build it, either.  Could we just 
create a brief inner wrapper class here with its only member as `rootView` and 
then make `experimental` a member of `ProcessorFactory` of that wrapper type?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to