mbeckerle commented on a change in pull request #402:
URL: https://github.com/apache/incubator-daffodil/pull/402#discussion_r461829149
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PState.scala
##########
@@ -197,6 +197,7 @@ final class PState private (
def mark(requestorID: String): PState.Mark = {
// threadCheck()
+ changedVariablesStack.push(mutable.MutableList[GlobalQName]())
Review comment:
Please add comment that there is an invariant that every mark must be
either reset to, or discarded in order for this stack to be properly
maintained.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
