stevedlawrence commented on a change in pull request #466:
URL: https://github.com/apache/incubator-daffodil/pull/466#discussion_r546017426
##########
File path:
daffodil-runtime2/src/main/scala/org/apache/daffodil/runtime2/Runtime2DataProcessor.scala
##########
@@ -108,6 +108,8 @@ class Runtime2DataProcessor(executableFile: os.Path)
extends DFDL.DataProcessorB
val parseResult = new ParseResult(outfile, Failure(parseError))
parseResult.addDiagnostic(parseError)
parseResult
+ } finally {
+ os.remove.all(tempDir)
Review comment:
OS-lib does look interesting. We should consider updates to use it
throughout Daffodil it we think it's worth using in one part. I'd really like
to keep the codebase as consistent as possible.
Considering MPL has extra licensing requirements, and if we're only using
directories-jvm for getting a per OS cache directory, I've vote for just
implementing that logic ourselves.
THe NOTICE requirement ususally only comes from Apache licensed things. So
probably no change needs to be made for the bin.NOTICE. The MPL rquirement
suggests adding some line in the REAMDE. The apache licensing page says:
> An appropriate and prominent label is a label the user will read while
learning about the distribution - for example in a README, and it should
identify the third-party product, its licensing, and a url to the its homepage.
Please also ensure to comply with any attribution/notice requirements in the
specific license in question.
So if we do include this, we probably need to include that information the
daffodil-cli README file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
