tuxji commented on a change in pull request #485:
URL: https://github.com/apache/incubator-daffodil/pull/485#discussion_r568631104
##########
File path:
daffodil-cli/src/it/scala/org/apache/daffodil/parsing/TestCLIParsing.scala
##########
@@ -206,27 +206,19 @@ class TestCLIparsing {
}
@Test def test_1593_CLI_Parsing_MultifileSchema_noGlobalElem(): Unit = {
- val tmp_filename: String = (System.currentTimeMillis / 1000).toString()
- val file = new File(tmp_filename)
- val schemaFile =
Util.daffodilPath("daffodil-test/src/test/resources/org/apache/daffodil/section06/entities/TopLevel.dfdl.xsd")
- val inputFile =
Util.daffodilPath("daffodil-test/src/test/resources/org/apache/daffodil/section06/entities/02nine_headers.txt")
- val (testSchemaFile, testInputFile) = if (Util.isWindows)
(Util.cmdConvert(schemaFile), Util.cmdConvert(inputFile)) else (schemaFile,
inputFile)
-
- val shell = Util.start("")
+ val schemaFile =
Util.daffodilPath("daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/multi_base_21.dfdl.xsd")
+ val testSchemaFile = if (Util.isWindows) Util.cmdConvert(schemaFile) else
schemaFile
+ val shell = Util.startIncludeErrors("")
try {
- val cmd = String.format("%s parse -s %s -o %s %s", Util.binPath,
testSchemaFile, tmp_filename, testInputFile)
+ val cmd = String.format(Util.echoN("does not matter") + " | %s parse -s
%s", Util.binPath, testSchemaFile)
Review comment:
Nice use of echo to avoid creating/deleting a temporary input file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
