tuxji commented on a change in pull request #517:
URL: https://github.com/apache/daffodil/pull/517#discussion_r600747459
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section14/sequence_groups/SequenceGroupNestedArray.tdml
##########
@@ -219,6 +219,7 @@ notice blank lines are skipped
<ex:record>
<ex:item>notice lines of all commas are skipped</ex:item>
</ex:record>
+ <ex:record />
Review comment:
If I were you, I also would run an experiment. Edit
SequenceGroupNestedArray.tdml, define `emptyValueDelimiterPolicy="none"` after
inheriting DFDLGeneralFormat.dfdl.xsd, and rerun the test. Does Daffodil still
add the empty record item to the infoset? The spec says:
> Optional occurrence: if dfdl:emptyValueDelimiterPolicy is applicable and
is not 'none' [29], then an item is added to the Infoset, otherwise nothing is
added to the Infoset.
I know that there is a caveat "if dfdl:emptyValueDelimiterPolicy is
applicable" and that policy applies only when an element defines an initiator
and/or terminator, otherwise it does not apply. Example 9.4.2.4 also says
emptyValueDelimiterPolicy does not apply to it. However, this experiment might
reveal a bug in Daffodil if Daffodil suddenly reverses its position and stops
adding the empty record item to the infoset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
