mbeckerle commented on a change in pull request #529:
URL: https://github.com/apache/daffodil/pull/529#discussion_r614210213
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/layers/layers.tdml
##########
@@ -383,7 +383,7 @@ jones,arya,cat,1986-02-19
We gzip that, and then we must prepend that with the length (as a binary
4-byte int) before we base64 encode.
-->
- <tdml:documentPart type="text"
replaceDFDLEntities="true"><![CDATA[AAAAcx+LCAAAAAAAAAAtyUEKgCAQheG94E1mIDWittG+M0xpaNQIo5tuX0Kb98P7LioVjiTf3sn7%CR;%LF;K8CyzlqVO9UIkrcgFTYh9pnBTOOInUPba3XmyOX7WiEGlqfxgJ1B6xpzKEDyEOxUf7JoJq1e/RI4%CR;%LF;wXIAAAA=--END--]]></tdml:documentPart>
+ <tdml:documentPart type="text"
replaceDFDLEntities="true"><![CDATA[AAAAcx+LCAAAAAAAAP8tyUEKgCAQheG94E1mIDWittG+M0xpaNQIo5tuX0Kb98P7LioVjiTf3sn7%CR;%LF;K8CyzlqVO9UIkrcgFTYh9pnBTOOInUPba3XmyOX7WiEGlqfxgJ1B6xpzKEDyEOxUf7JoJq1e/RI4%CR;%LF;wXIAAAA=--END--]]></tdml:documentPart>
Review comment:
So this behavior change for Java 16 is permanent, and the old behavior
was clearly wrong, so we should adopt this new behavior going forward, and the
fixer should be applied to Java releases prior to this change (actually, what
revision introduced this fix, it may be earlier than 16?)
So we should change everything to adopt the Java 16 corrected behavior in
the tests, and use the fixer for earlier versions of Java prior to 16
conditionally, based on detecting them.
I agree a TDML runner enhancement doesn't seem needed.
Question: Does just changing tests to twoPass fix the tests? If we don't
actually compare the gzipped data, but rather compare the infosets, as a
twoPass test does, maybe that is the easiest thing to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
