stevedlawrence commented on a change in pull request #668:
URL: https://github.com/apache/daffodil/pull/668#discussion_r736565158
##########
File path: project/Dependencies.scala
##########
@@ -50,7 +50,7 @@ object Dependencies {
lazy val test = Seq(
"junit" % "junit" % "4.13.2" % "it,test",
- "com.novocode" % "junit-interface" % "0.11" % "it,test",
+ "com.github.sbt" % "junit-interface" % "0.13.2" % "it,test",
Review comment:
I noticed that this new version gives a new control over verbosity. If
we want, we could change this line:
```
testOptions += Tests.Argument(TestFrameworks.JUnit, "-q", "-v"),
```
to this
```
testOptions += Tests.Argument(TestFrameworks.JUnit, "-q", "--verbosity=1"),
```
That essentially changes verbosity from 2 to 1, which means all the
"started" messages do not appear. This means we only output a single summary
line for each test suite, and details about failed tests if there were any. For
example, the new output looks something like this (I added a failed test):
```
...
[info] Test run org.apache.daffodil.util.TestListMap finished: 0 failed, 0
ignored, 1 total, 0.176s
[info] Test run org.apache.daffodil.TestImplicits finished: 0 failed, 0
ignored, 3 total, 0.003s
[info] Test run org.apache.daffodil.util.TestSchemaUtils finished: 0 failed,
0 ignored, 1 total, 0.019s
[error] Test org.apache.daffodil.xml.test.unit.TestXMLUtils.testDiff0
failed: org.junit.ComparisonFailure: expected:<[a]> but was:<[b]>, took 0.012
sec
[error] at
org.apache.daffodil.xml.test.unit.TestXMLUtils.testDiff0(TestXMLUtils.scala:45)
[error] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
[error] at
jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[error] at
jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[error] at java.lang.reflect.Method.invoke(Method.java:568)
[error] ...
[info] Test run org.apache.daffodil.xml.test.unit.TestNamespaces finished: 0
failed, 0 ignored, 7 total, 0.004s
[info] Test run org.apache.daffodil.xml.test.unit.TestXMLUtils finished: 1
failed, 0 ignored, 27 total, 0.465s
[info] Test run org.apache.daffodil.functionality.icu.TestBigInteger
finished: 0 failed, 0 ignored, 1 total, 0.507s
[info] Test run org.apache.daffodil.exceptions.TestExceptions finished: 0
failed, 0 ignored, 1 total, 0.001s
...
```
Note that the sbt color output makes this a bit easier to read. This makes
it much easier to find failed tests since there isn't so much unnecessary "foo
started" stuff, but it also makes it more difficult to see exactly which tests
are run, which can be useful, especially when adding new tests to verify they
are run. Any thoughts on this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
