mbeckerle commented on a change in pull request #770:
URL: https://github.com/apache/daffodil/pull/770#discussion_r825175804



##########
File path: 
daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsCharsetDecoder.scala
##########
@@ -32,6 +31,13 @@ import org.apache.daffodil.util.MaybeChar
 class BitsCharsetDecoderMalformedException(val malformedBits: Int)
   extends ThinException
 
+class BitsCharsetDecoderUnalignedCharDecodeException(val bitAlignment1b: Long)
+  extends ThinException {
+  override def getMessage(): String = {
+    s"Charset not byte aligned. Bit alignment (1b): ${bitAlignment1b}."

Review comment:
       Arguably we should save the bitPos1b and have the message refer to both 
the bitAlignment1b, the bitPos1b and the bytePos1b since it depends on the data 
what is useful to the user. 
   I will improve this. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to