mbeckerle commented on code in PR #1106: URL: https://github.com/apache/daffodil/pull/1106#discussion_r1376450021
########## daffodil-lib/src/test/scala/org/apache/daffodil/lib/util/TestFixedICUDecimalFormat.java: ########## @@ -0,0 +1,159 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.daffodil.lib.util; + +import com.ibm.icu.text.DecimalFormat; +import com.ibm.icu.text.DecimalFormatSymbols; +import org.junit.Test; +import static junit.framework.TestCase.assertEquals; +import static org.junit.Assert.*; + +import java.util.Locale; +import java.util.Objects; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +/** + * Tests about ICU-22558 + * + * https://unicode-org.atlassian.net/browse/ICU-22558 + */ +public class TestFixedICUDecimalFormat { + + // Create DecimalFormatSymbols for a Locale where the decimal separator is a dot + DecimalFormatSymbols symbols = new DecimalFormatSymbols(Locale.US); + + /** + * Illustrates the bug in ICU. + */ + @Test + public void testDecimalFormatWithHash() { + // Create DecimalFormat instance with the pattern "#.##" + DecimalFormat decimalFormat = new DecimalFormat("#.##", symbols); Review Comment: No, because 1.0 then fails with a truncation no-rounding possible error. Making the user use two different format patterns is also no good as that would require the schema author to understand this bug, and literally conditionalize their schema for whether the value is between 0.0 and 1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
