stevedlawrence commented on PR #1182: URL: https://github.com/apache/daffodil/pull/1182#issuecomment-1995440563
> Is it concerning that no tests needed any changes after switching these two mappings? We just don't have any tests that use the deprecated `separatorPolicy` property with either `trailingEmptyLax` or `trailingEmptyStrict`, so this part of the mapping was never actually hit. Most of our separator suppression tests use the newer `separatorSuppressionPolicy` property values of `trailingEmpty` and `trailingEmptyStrict` are tested. We could add some tests to make sure this mapping works correctly, but I'm not sure it's worth it. We know the core functionality works, and by inspection it's pretty clear the mapping is correct now. And this is a deprecated property that should go away eventually anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
