tuxji commented on code in PR #1199: URL: https://github.com/apache/daffodil/pull/1199#discussion_r1546386712
########## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/dpath/ComparisonOps.scala: ########## @@ -17,10 +17,176 @@ package org.apache.daffodil.runtime1.dpath +import org.apache.daffodil.lib.exceptions.Assert import org.apache.daffodil.lib.util.Numbers._ +import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType import org.apache.daffodil.runtime1.infoset.DataValue.DataValueBool import org.apache.daffodil.runtime1.infoset.DataValue.DataValuePrimitive +/** + * Case class used for ordering the return of the appropriate comparison operations for each primitive kind + * @param eq represents the equality comparison + * @param ne represents the unequality comparison + * @param lt represents the less than comparison + * @param le represents the less than and equal to comparison Review Comment: less than or equal to ########## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/dpath/ComparisonOps.scala: ########## @@ -17,10 +17,176 @@ package org.apache.daffodil.runtime1.dpath +import org.apache.daffodil.lib.exceptions.Assert import org.apache.daffodil.lib.util.Numbers._ +import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType import org.apache.daffodil.runtime1.infoset.DataValue.DataValueBool import org.apache.daffodil.runtime1.infoset.DataValue.DataValuePrimitive +/** + * Case class used for ordering the return of the appropriate comparison operations for each primitive kind + * @param eq represents the equality comparison + * @param ne represents the unequality comparison + * @param lt represents the less than comparison + * @param le represents the less than and equal to comparison + * @param gt represents the greater than comparison + * @param ge represents the greater than and equal to comparison Review Comment: greater than or equal to -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
