arosien commented on code in PR #1022:
URL: https://github.com/apache/daffodil-vscode/pull/1022#discussion_r1597059970
##########
src/tdmlEditor/utilities/tdmlXmlUtils.ts:
##########
@@ -260,9 +260,36 @@ export async function getTestCaseDisplayData(
* See the 'Invalid Append TDML - duplicate' and 'Append TDML Test Case' tests
for examples
*/
export async function appendTestCase(
- xmlBuffer: string,
- destinationBuffer: string
+ xmlFilePath: string,
+ destinationFilePath: string
+) {
+ return copyTestCase(xmlFilePath, destinationFilePath, true)
+}
+
+/*
+ * Copy and optionally append test case in one XML file into another file's
test suite
+ *
+ * xmlFilePath: String containing the XML file path of a TDML file with
+ * exactly one test case
Review Comment:
Concern: it doesn't really expect a TDML file with only one test case, does
it? Then append would only work once and never again on the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
