tuxji commented on code in PR #31:
URL: https://github.com/apache/daffodil-sbt/pull/31#discussion_r1603889578
##########
src/main/scala/org/apache/daffodil/DaffodilPlugin.scala:
##########
@@ -318,28 +325,44 @@ object DaffodilPlugin extends AutoPlugin {
)
}
- // force creation of saved parsers
+ // force creation of saved parsers, there isn't currnty a way to build
them for just
Review Comment:
*currently
##########
README.md:
##########
@@ -128,6 +128,11 @@ Note that only saved parsers for `daffodilVersion` can be
referenced. For this
reason, `daffodilVersion` must also be defined in `daffodilPackageBinVersions`
if `daffodilTdmlUsesPackageBin` is `true`.
+This is implemented using a SBT resource generator which some IDE's, like
+IntelliJ, do not trigger during builds. So you must either run `sbt
Test/compile`
+to manually trigger the resource generator, or let SBT handle builds by
+enabling the "Use SBT shell for builds" option.
Review Comment:
BTW, enabling "use sb shell for builds" is also needed to build Daffodil
itself.
##########
src/main/scala/org/apache/daffodil/DaffodilPlugin.scala:
##########
@@ -318,28 +325,44 @@ object DaffodilPlugin extends AutoPlugin {
)
}
- // force creation of saved parsers
+ // force creation of saved parsers, there isn't currnty a way to build
them for just
+ // daffodilVersion
val allSavedParsers = packageDaffodilBin.value
- // create a directory that we will put on the classpath, deleting it
and all contents
- // if it already exists
- val parserClasspathDir = target.value / "tdmlparsers"
- IO.delete(parserClasspathDir)
- IO.createDirectory(parserClasspathDir)
-
- // copy the saved parsers for daffodilVersion into our classpath
directory
- daffodilPackageBinInfos.value.foreach { case (_, _, optName) =>
+ // copy the saved parsers for the currnt daffodilVersion to the root
of the
Review Comment:
*current
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
