stevedlawrence commented on PR #1253:
URL: https://github.com/apache/daffodil/pull/1253#issuecomment-2148235355
> @stevedlawrence Does this have any interaction with our pluggable
validators, e.g, schematron?
Pluggable validators shouldn't see any difference. This change only made it
so XercesValidator's are shared between DataProcessor ,custom validators have
always been shared. For example, if you did something like this:
```scala
val validator = Validators.get("MyCustomValidator").make()
val dp1 = dp.withValidationMode(ValidationMode.Custom(validator))
val dp2 = dp1.withTunable(...)
```
Then both `dp1` and `dp2` would use the same custom validator. This is
because custom validators are stored in the `validationMode`, which was already
copied by the `withXYZ` functions. But XercesValidators aren't stored in
`validationMode`, which is essentially what led to us not being able to share
them.
It would be a breaking change to store XercesValidators in the
validationMode, so this added a new member that is just for storing the
validator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
