[
https://issues.apache.org/jira/browse/DAFFODIL-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Thompson closed DAFFODIL-2331.
-----------------------------------
Verified the specified commit (commit 48372e11756eca6e3ce56aafe5024ba02a7cdb27)
is included in the latest pull from the daffodil repository.
Verified, via review, changes identified in the commit comment were
implemented.
Verified the affected daffodil subproject sbt test suites executed successfully.
Verified the nightly test suite executes successfully with no unexpected
failures.
> Remove argType parameter from FNZeroArgExpr and derived classes
> ---------------------------------------------------------------
>
> Key: DAFFODIL-2331
> URL: https://issues.apache.org/jira/browse/DAFFODIL-2331
> Project: Daffodil
> Issue Type: Improvement
> Components: Clean Ups
> Reporter: John Interrante
> Assignee: Alex Parker
> Priority: Minor
> Labels: beginner
> Fix For: 3.9.0
>
>
> Expression.scala uses FNZeroArgExpr to implement fn:local-name,
> fn:namespace-uri, dfdlx:outputTypeCalcNextSibling, dfdlx:repTypeValue, and
> dfdlx:logicalTypeValue functions. It has to pass NodeInfo.XXX for the
> argType parameter, even though the argType parameter shouldn't be needed if
> there are zero arguments. Should we remove this parameter? It looks like
> argType is used only in targetTypeForSubexpression, which should never be
> called in FNZeroArgExpr since there are zero arguments.
> If we remove the argType parameter, we also shouldn't need to pass argType to
> the constructor for FNNamespaceURI0 and similar classes in FNFunctions.scala.
> People who can answer questions about this issue are Steve Lawrence and
> myself (although Steve can answer questions better).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
