stevedlawrence commented on code in PR #1338:
URL: https://github.com/apache/daffodil/pull/1338#discussion_r1842613813
##########
daffodil-codegen-c/src/main/scala/org/apache/daffodil/codegen/c/DaffodilCCodeGenerator.scala:
##########
@@ -289,7 +289,8 @@ object DaffodilCCodeGenerator
case g: ElementParseAndUnspecifiedLength =>
elementParseAndUnspecifiedLengthGenerateCode(g, cgState)
case g: ElementUnused => noop(g)
- case g: HexBinaryLengthPrefixed =>
hexBinaryLengthPrefixedGenerateCode(g.e, cgState)
+ case g: HexBinaryEndOfBitLimit if g.e.isPrefixed =>
Review Comment:
Sorry that wasn't clear. I'm suggesting that we should keep the old grammar
name `HexBinaryLengthPrefixed` so this change isn't needed. This way the
grammar is a more clear for things like the code generator that examine it. But
it's still fine to call the parsers `BitLimitLength/MinimumLength` etc from
that grammar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
