mbeckerle commented on code in PR #1422:
URL: https://github.com/apache/daffodil/pull/1422#discussion_r1945371865
##########
daffodil-propgen/src/main/scala/org/apache/daffodil/propGen/TunableGenerator.scala:
##########
@@ -352,12 +352,12 @@ class TunableEnumDefinition(
""".trim.stripMargin
private val scalaEnums = {
- val scalaEnumValues = allEnumerationValues.map { e => e.head.toUpper +
e.tail }
+ val scalaEnumValues = allEnumerationValues.map { e =>
s"${e.head.toUpper}${e.tail}" }
Review Comment:
Gaaak. A String is a `Seq[Char]`. Appending `T` to `Seq[T]` at the front of
the sequence is one of the most basic operations in functional programming. It
is `cons` from Lisp.
Perhaps `+` is the wrong operator here? Maybe these should be the actual
`cons` operator i.e., is that `char :: string` or `char +: string` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
