mbeckerle commented on code in PR #1424:
URL: https://github.com/apache/daffodil/pull/1424#discussion_r1949382045
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dpath/Expression.scala:
##########
@@ -110,7 +110,7 @@ abstract class Expression extends OOLAGHostImpl() with
BasicComponent {
res
}
- private lazy val compiledDPath_ = LV('compiledDPath) { compiledDPath }
+ private lazy val compiledDPath_ = LV(Symbol("compiledDPath")) {
compiledDPath }
Review Comment:
The only value of Symbol here I guess is that the strings will be interned.
But we only use these strings in documentation.
My actual plan for these LV things was to use Li Haoyi's sourcecode library
to obtain the symbol from the name of the lazy val itself, so that this whole
argument would just disappear entirely.
However, that's beyond the call of duty for this change set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
