olabusayoT commented on code in PR #1426:
URL: https://github.com/apache/daffodil/pull/1426#discussion_r1949387684
##########
daffodil-lib/src/test/scala/org/apache/daffodil/lib/util/TestMaybeInlineForeach.scala:
##########
@@ -99,9 +99,9 @@ final class TestMaybeInlineForeach {
*/
// @Test
def testForeachVersusIfDefined(): Unit = {
- val foreachNanos: Double = time(testForeach)
- val ifDefinedNanos: Double = time(testIfDefined)
- val ifNullNanos: Double = time(testIfNull)
+ val foreachNanos: Double = time(testForeach()).toDouble
+ val ifDefinedNanos: Double = time(testIfDefined()).toDouble
+ val ifNullNanos: Double = time(testIfNull()).toDouble
Review Comment:
Just to clarify, anywhere the parens were added was due to the 2.13 compiler
erroring out. And where the .to* method calls were added was for the same
reason....Attempting to add a paren to .toDouble resulted in the complaint
below, so I think we're stuck with the inconsistent application
```
Double does not take parameters
[error] val foreachNanos: Double = time(testForeach()).toDouble()```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
