stevedlawrence commented on code in PR #1440: URL: https://github.com/apache/daffodil/pull/1440#discussion_r1965949181
########## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/parsers/SequenceParserBases.scala: ########## @@ -32,15 +31,13 @@ import org.apache.daffodil.runtime1.processors.Success * Base class for all sequence parsers, which are the combinators that coordinate * all the parsing of the sequence child parsers. */ -abstract class SequenceParserBase( +abstract class SequenceParserBase[T]( Review Comment: I don't think it would reference any subclass. All the subclasses are SequenceParsers, but the `T` parameter is always a Sequence*Child*Parser, which doesn't extended SequenceParser. Removing the type parameter just means SequenceParsers _must_ contain children that are SequenceChildParsers and there's no way to have children of a different type, but I think that's a reasonable restriction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
