stricklandrbls commented on issue #1021: URL: https://github.com/apache/daffodil-vscode/issues/1021#issuecomment-2689291385
It's been a while since I've had a chance to look at this but iirc, this is happening because the initalization of the `DataEditorClient` the disposables are being pushed onto the `ExtensionContext::subscriptions[]` with the intention of having those `Disposable` object executed when the DataEditor window closes. What's really happening is that some, or all, of those disposables aren't executing because the `ExtensionContext` as a whole has not received any instruction to dispose of the items in that `subscriptions` array. The `ExtensionContext` encompasses the VSCode window in it's entirety, not just the DataEditor window. A quick fix for this might be to attach the DataEditor related disposal functions to when the panel is disposed: https://github.com/apache/daffodil-vscode/blob/27c6e022224007669de98f8407701d3956376885/src/dataEditor/dataEditorClient.ts#L164 But in realistically, since the logging is invoked from API functions provided by the OmegaEdit client via https://github.com/apache/daffodil-vscode/blob/27c6e022224007669de98f8407701d3956376885/src/dataEditor/dataEditorClient.ts#L929 then it should also provide an explicit function for stopping the logger or ensure that when a session is destroyed that logging is halted. @scholarsmate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
