mbeckerle commented on code in PR #8:
URL:
https://github.com/apache/daffodil-infrastructure/pull/8#discussion_r2033887443
##########
containers/check-release/src/check-release.sh:
##########
@@ -96,9 +96,9 @@ printf "\n==== Dist GPG Signatures ====\n"
find $DIST_DIR -type f ! -name '*.sha512' ! -name '*.asc' \
-exec bash -c "gpg --verify '{}.asc' '{}' $PRINT_FIND_RESULT" \;
-printf "\n==== RPM Signatures ====\n"
+printf "\n==== RPM Embedded Signatures ====\n"
find $DIST_DIR -type f -name '*.rpm' \
- -exec bash -c "rpm -K '{}' $PRINT_FIND_RESULT" \;
+ -exec bash -c "rpm -K '{}' | grep 'signatures OK' $PRINT_FIND_RESULT" \;
Review Comment:
Per "... we grep for the string "signatures OK"--this is only output if both
conditions hold."
The place that outputs this "signatures OK" (not modified in this change
set) needs doc/comments to indicate that it is output only if both conditions
hold since we're depending on that invariant here... unless it already has
them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
