This is an automated email from the ASF dual-hosted git repository.
shanedell pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/daffodil-vscode.git
The following commit(s) were added to refs/heads/main by this push:
new 546b7bb Remove Append as an Action for TDML in the launch wizard + VS
Code settings and remove relevant scala code
546b7bb is described below
commit 546b7bb805d72d9190bb4c40d8a629fa7f9759ee
Author: Jeremy Yao <[email protected]>
AuthorDate: Thu May 22 14:43:01 2025 -0400
Remove Append as an Action for TDML in the launch wizard + VS Code settings
and remove relevant scala code
Closes #1031
---
.../org.apache.daffodil.debugger.dap/Parse.scala | 19 ++-----------------
.../org.apache.daffodil.debugger/ParseSuite.scala | 2 +-
package.json | 3 +--
src/launchWizard/launchWizard.ts | 4 ++--
src/launchWizard/script.js | 1 -
5 files changed, 6 insertions(+), 23 deletions(-)
diff --git
a/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala
b/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala
index a913304..256b339 100644
--- a/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala
+++ b/debugger/src/main/scala/org.apache.daffodil.debugger.dap/Parse.scala
@@ -340,7 +340,7 @@ object Parse {
// }
//
// The action field is parsed first.
- // If it is a valid action ('generate' | 'append' | 'execute' | 'none'),
create a LaunchArgs object of the appropriate type
+ // If it is a valid action ('generate' | 'execute' | 'none'), create a
LaunchArgs object of the appropriate type
// If it is 'none' or missing, create a LaunchArgs.Manual object. This
will ignore any other fields in the tdmlConfig object.
//
// arguments: Launch config
@@ -376,21 +376,6 @@ object Parse {
parseVariables(arguments),
parseTunables(arguments)
).parMapN(LaunchArgs.TDMLConfig.Generate.apply)
- case "append" =>
- (
- parseSchema(arguments),
- parseData(arguments),
- parseStopOnEntry(arguments),
- parseInfosetFormat(arguments),
- parseInfosetOutput(arguments, true),
- parseTDMLName(tdmlConfig),
- parseTDMLDescription(tdmlConfig),
- parseTDMLPath(tdmlConfig),
- parseRootName(arguments),
- parseRootNamespace(arguments),
- parseVariables(arguments),
- parseTunables(arguments)
- ).parMapN(LaunchArgs.TDMLConfig.Append.apply)
case "execute" =>
(
parseStopOnEntry(arguments),
@@ -418,7 +403,7 @@ object Parse {
).parMapN(LaunchArgs.Manual.apply)
case invalidType =>
Left(
- s"invalid 'tdmlConfig.action': '$invalidType', must be
'generate', 'append', 'none', or 'execute'"
+ s"invalid 'tdmlConfig.action': '$invalidType', must be
'generate', 'none', or 'execute'"
).toEitherNel
}
}
diff --git
a/debugger/src/test/scala/org.apache.daffodil.debugger/ParseSuite.scala
b/debugger/src/test/scala/org.apache.daffodil.debugger/ParseSuite.scala
index f57e1c7..e16391c 100644
--- a/debugger/src/test/scala/org.apache.daffodil.debugger/ParseSuite.scala
+++ b/debugger/src/test/scala/org.apache.daffodil.debugger/ParseSuite.scala
@@ -138,7 +138,7 @@ class ParseSuite extends FunSuite {
assertEquals(parseResult.isLeft, true)
assertEquals(
parseResult.swap.toOption.map(_.head).getOrElse("no error"),
- "invalid 'tdmlConfig.action': 'InvalidAction', must be 'generate',
'append', 'none', or 'execute'"
+ "invalid 'tdmlConfig.action': 'InvalidAction', must be 'generate',
'none', or 'execute'"
)
}
diff --git a/package.json b/package.json
index b283d27..ae2ba0c 100644
--- a/package.json
+++ b/package.json
@@ -572,11 +572,10 @@
"enum": [
"none",
"generate",
- "append",
"execute"
],
"default": "generate",
- "description": "TDML Case Action (none | generate | append
| exectute)"
+ "description": "TDML Case Action (none | generate |
exectute)"
},
"name": {
"type": "string",
diff --git a/src/launchWizard/launchWizard.ts b/src/launchWizard/launchWizard.ts
index e204519..db2815f 100644
--- a/src/launchWizard/launchWizard.ts
+++ b/src/launchWizard/launchWizard.ts
@@ -496,7 +496,7 @@ class LaunchWizard {
})
let tdmlActionSelect = 'none'
- let tdmlActions = ['none', 'generate', 'append', 'execute']
+ let tdmlActions = ['none', 'generate', 'execute']
let tdmlAction =
'tdmlConfig' in defaultValues ? defaultValues.tdmlConfig['action'] : null
let tdmlName =
@@ -733,7 +733,7 @@ class LaunchWizard {
<div id="tdmlActionDiv" class="setting-div">
<p>TDML Action:</p>
- <p class="setting-description">TDML Action (none | generate | append |
execute)</p>
+ <p class="setting-description">TDML Action (none | generate |
execute)</p>
<select onChange="updateTDMLAction()" class="file-input" style="width:
200px;" id="tdmlAction">
${tdmlActionSelect}
</select>
diff --git a/src/launchWizard/script.js b/src/launchWizard/script.js
index fe01532..1a4bd78 100644
--- a/src/launchWizard/script.js
+++ b/src/launchWizard/script.js
@@ -326,7 +326,6 @@ function save() {
break
case 'generate':
obj.configurations[0].tdmlConfig.path = configValues.tdmlPath
- case 'append':
case 'execute':
obj.configurations[0].tdmlConfig.name = configValues.tdmlName
obj.configurations[0].tdmlConfig.description =
