stevedlawrence commented on code in PR #1509:
URL: https://github.com/apache/daffodil/pull/1509#discussion_r2229016742
##########
build.sbt:
##########
@@ -58,7 +58,7 @@ lazy val daffodil = project
lazy val macroLib = Project("daffodil-macro-lib", file("daffodil-macro-lib"))
.settings(commonSettings, nopublish)
- .settings(libraryDependencies += "org.scala-lang" % "scala-reflect" %
scalaVersion.value)
+ .settings(libraryDependencies += "org.scala-lang" % "scala-reflect" %
"2.13.16")
Review Comment:
This seems a bit odd, will this cause issues if we always depend on 2.13.16
even though we are building scala 3? Should this only add scala-reflect if
scalaVersion is 2.13.x? Similar to what you have in Dependencies.scala?
##########
project/Dependencies.scala:
##########
@@ -19,7 +19,12 @@ import sbt.*
object Dependencies {
- lazy val common = core ++ infoset ++ test
+ def common(scalaVersion: String) = core ++ infoset ++ test ++ {
+ CrossVersion.partialVersion(scalaVersion) match {
+ case Some((2, 13)) => Seq("org.scala-lang" % "scala-reflect" % "2.13.16")
Review Comment:
It looks like before this change scala-reflect was only needed by the
macroLib. Should this be removed from common and instead this logic added to
build.sbt with the daffodil-macro project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
