michael-hoke commented on code in PR #1336:
URL: https://github.com/apache/daffodil-vscode/pull/1336#discussion_r2240562810
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -137,7 +137,7 @@ async function showTDMLSaveDialog(fileRequested, label,
title) {
}
// Function for setting up the commands for Run and Debug file
-function createDebugRunFileConfigs(
+async function createDebugRunFileConfigs(
Review Comment:
This needs to be reverted. When you make a function `async`, any callers
need to either `await` the function or use a thenable. If neither of those
happen, execution order will change depending on how it's called. Even if this
works now, we could be creating issues for ourselves down the road when this
starts causing issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
