olabusayoT commented on code in PR #116:
URL: https://github.com/apache/daffodil-sbt/pull/116#discussion_r2245553474
##########
src/main/scala/org/apache/daffodil/DaffodilPlugin.scala:
##########
@@ -355,8 +355,11 @@ object DaffodilPlugin extends AutoPlugin {
"<=3.10.0" -> "2.12"
)
val crossVersion = filterVersions(binDaffodilVersion,
daffodilToCrossVersion).head
- val dafDep = ("org.apache.daffodil" % "daffodil-japi" %
binDaffodilVersion % cfg)
- .withCrossVersion(CrossVersion.constant(crossVersion))
+ val dafDep = {
+ val dep = if (crossVersion == "3") ("org.apache.daffodil" %
"daffodil-core" % binDaffodilVersion % cfg)
Review Comment:
hmm this is a bit hard to read, could be move the then's to a new line and
maybe the condition also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
