stevedlawrence commented on code in PR #1521:
URL: https://github.com/apache/daffodil/pull/1521#discussion_r2276655163


##########
daffodil-core/src/main/scala/org/apache/daffodil/lib/iapi/Diagnostic.scala:
##########
@@ -128,8 +128,6 @@ abstract class Diagnostic protected (
    */
   override def getMessage(): String = message
 
-  override def getMessageOnly: String = message

Review Comment:
   toString already contains this:
   
   > Get a string containing the mode name, message, schema location, and data 
location combined into a single string
   
   I also just pushed a fixup to clarify getMessage and recommend toString so 
it now says:
   
   >  Get the diagnostic mode name
   >
   > This does not include any additional details about the Diagnostic, such as
   > mode name, schema context, or data location. For a human-readable
   > representation of this diagnostic, including the message and all context
   > information, use {@link #toString()}.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to