hdalsania opened a new pull request, #1401:
URL: https://github.com/apache/daffodil-vscode/pull/1401
Closes #1374
Let's review following issue templates
- Bug_Report
- Enhancement_Request
- Feature_Request
Let's review pull request template also as a part of this PR.
Pull request template includes checkboxes for wiki documentation and we can
enforce this by updating PR Workflow (for disallowing a merge if the checkbox
isn't checked by adding following jon in CI.yaml file.
Please share your thoughts on that.
```
name: Enforce Wiki Checkbox
on:
pull_request:
types: [opened, edited, synchronize, reopened]
jobs:
enforce-checkbox:
runs-on: ubuntu-latest
steps:
- name: Check required confirmation checkbox
uses: actions/github-script@v7
with:
script: |
const prBody = context.payload.pull_request.body || "";
const checkbox1Text = "- [x] I have determined that no wiki
updates are needed for these changes";
const checkbox2Text = "- [x] I have added documentation to the
wiki for these changes";
if (!prBody.includes(checkbox1Text) &&
!prBody.includes(checkbox2Text) {
core.setFailed("❌ Required wiki checkbox not checked. Please
check the box before merging.");
} else {
core.info("✅ Required wiki checkbox is checked.");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
