shanedell commented on code in PR #1382:
URL: https://github.com/apache/daffodil-vscode/pull/1382#discussion_r2320576052
##########
src/svelte/tsconfig.json:
##########
@@ -18,15 +18,33 @@
{
"extends": "@tsconfig/svelte/tsconfig.json",
"compilerOptions": {
- "module": "esnext",
- "moduleResolution": "Node10",
- "baseUrl": "../",
- "target": "es6",
- "outDir": "out",
- "lib": ["es6", "es2021", "DOM"],
- "ignoreDeprecations": "5.0"
+ "allowImportingTsExtensions": true,
+ "noEmit": true,
+ "inlineSources": true,
+ "baseUrl": "./src",
+ "paths": {
+ "utilities": ["utilities"],
+ "layout/*": ["components/layouts/*"],
+ "HTMLWrappers/*": ["components/html/*"],
+ "editor_components/*": ["components/sections/*"]
+ },
+ // "allowImportingTsExtensions": true,
+ "target": "ES6",
+ "useDefineForClassFields": true,
+ "module": "CommonJS",
Review Comment:
```suggestion
"module": "commonjs",
```
I believe this misspelling is causing the issue in CI, I believe since
`CommonJS` is not a module type it is by default trying to run this as a ESM
module instead. To confirm this, see the `tsconfig.json` in the root of the
repo as it uses `"module": "commonjs"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
