stevedlawrence commented on code in PR #1566:
URL: https://github.com/apache/daffodil/pull/1566#discussion_r2378914943
##########
daffodil-test/src/test/resources/org/apache/daffodil/section12/lengthKind/PrefixedTests.tdml:
##########
@@ -154,6 +160,12 @@
dfdl:prefixIncludesPrefixLength="yes" />
<xs:element name="pl_text_int_txt_chars_includes" type="xs:int"
dfdl:ref="prefixedTxtChar"
dfdl:prefixIncludesPrefixLength="yes"
dfdlx:parseUnparsePolicy="parseOnly" />
+ <xs:element name="pl_text_string_text_chars_doesnt_include"
type="xs:string"
Review Comment:
I think this test basically already exists as `pl_text_string_txt_chars`?
That root element references the format `prefixedTxtChar` which defines
`lengthUnits="characters"` and the default format of the model is
`prefixIncludesPrefixLength="no"`.
I'm guessing we fixed the issue in another bug and didn't realize the
duplication of tickets?
Also, it looks like `pl_complexContentLengthCharacters_utf8_1` is a test
that shows that unparsing fails if the encoding is variable-width (UTF-8) and
`pl_complexContentLengthCharacters_1` shows that unparsing works for
fixed-width encoding (UTF-16BE). Those tests both use LU=characters and PIP=no.
So I *think* we already have sufficient coverage this combination of
properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
