scholarsmate commented on code in PR #1426:
URL: https://github.com/apache/daffodil-vscode/pull/1426#discussion_r2382915395
##########
src/language/providers/elementCompletion.ts:
##########
@@ -288,22 +288,15 @@ function nearestOpenTagChildElements(
'',
nsPrefix
)
- case 'restriction':
- return getElementCompletionItems(
- [
- 'maxInclusive',
- 'maxExclusive',
- 'minInclusive',
- 'minExclusive',
- 'pattern',
- 'totalDigits',
- 'fractionDigits',
- 'enumeration',
- ],
- '',
- '',
- nsPrefix
- )
+ //restriction doesn't seem to have any child elements
+ // case 'restriction':
+ // return getElementCompletionItems(
+ // [
+ // ],
+ // '',
+ // '',
+ // nsPrefix
+ // )
Review Comment:
Just get rid of this.
##########
src/language/providers/attributeCompletion.ts:
##########
@@ -393,32 +393,95 @@ function checkNearestOpenItem(
return getCompletionItems(
[
'name',
+ 'maxOccurs',
+ 'minOccurs',
+ 'nillable',
'ref',
'type',
- 'minOccurs',
- 'maxOccurs',
+ 'default',
+ 'fixed',
'dfdl:occursCount',
'dfdl:bitOrder',
'dfdl:byteOrder',
- 'dfdl:occursCountKind',
- 'dfdl:length',
- 'dfdl:lengthKind',
'dfdl:encoding',
+ 'dfdl:utf16Width',
+ 'dfdl:encodingErrorPolicy',
'dfdl:alignment',
- 'dfdl:lengthUnits',
- 'dfdl:lengthPattern',
- 'dfdl:inputValueCalc',
- 'dfdl:outputValueCalc',
'dfdl:alignmentUnits',
- 'dfdl:binaryNumberRep',
+ 'dfdl:fillbyte',
+ 'dfdl:leadingSkip',
+ 'dfdl:trailingSkip',
+ 'dfdl:initiator',
'dfdl:terminator',
+ 'dfdl:emptyValueDelimiterPolicy',
'dfdl:outputNewLine',
- 'dfdl:choiceBranchKey',
+ 'dfdl:emptyElementParsePolicy',
+ 'dfdl:lengthKind',
+ 'dfdl:lengthUnits',
+ 'dfdl:length',
'dfdl:prefixIncludesPrefixLength',
'dfdl:prefixLengthType',
+ 'dfdl:lengthPattern',
'dfdl:representation',
+ 'dfdl:textPadKind',
+ 'dfdl:textTrimKind',
+ 'dfdl:textOutputMinLength',
+ 'dfdl:escapeSchemeRef',
+ 'dfdl:textBidi',
+ 'dfdl:textStringustification',
+ 'dfdl:textStringPadChar',
+ 'dfdl:truncateSpecifiedLengthString',
+ 'dfdl:decimalSigned',
+ 'dfdl:textNumberRep',
+ 'dfdl:textNumberJustification',
+ 'dfdl:textNumberPadCharacter',
+ 'dfdl:textNumberPattern',
+ 'dfdl:textnumberRounding',
+ 'dfdl:textNumberRoundingMode',
+ 'dfdl:textNumberRoundingIncrement',
+ 'dfdl:textNumberCheckPolicy',
+ 'dfdl:textStandardDecimalSeparator',
+ 'dfdl:textStandardGroupingSeparator',
+ 'dfdl:textStandardExponentRep',
+ 'dfdl:textStandardInfinityRep',
+ 'dfdl:textStandardNaNRep',
+ 'dfdl:textStandardZeroRep',
+ 'dfdl:textStandardBase',
+ 'dfdl:textZonedSignStyle',
+ 'dfdl:binaryNumberRep',
+ 'dfdl:binaryDecimalVirtualPoint',
+ 'dfdl:binaryPakedSignCodes',
+ 'dfdl:binaryNumberCheckPolicy',
+ 'dfdl:binaryFloatRep',
+ 'dfdl:textBooleanTrueRep',
+ 'dfdl:textBooleanFalseRep',
+ 'dfdl:textBooleanJustification',
+ 'dfdl:textBooleanPadChar',
'dfdl:binaryBooleanTrueRep',
- 'dfdl:binaryBooleanFalseRep',
+ 'dfdl:binaryBoolenaFalseRep',
Review Comment:
Spelling error, should be `dfdl:binaryBooleanFalseRep`, not
`dfdl:binaryBoolenaFalseRep`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
