stevedlawrence commented on code in PR #1567:
URL: https://github.com/apache/daffodil/pull/1567#discussion_r2398434496
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/primitives/PrimitivesBCD.scala:
##########
@@ -64,7 +64,8 @@ class BCDDecimalRuntimeLength(val e: ElementBase) extends
Terminal(e, true) {
e.elementRuntimeData,
e.binaryDecimalVirtualPoint,
e.lengthEv,
- e.lengthUnits
+ e.lengthUnits,
+ e.decimalSigned
Review Comment:
A number of BCD Parsers still accept `e.decimalSigned`. This should be
removed to match the BCD unparsers.
##########
daffodil-core/src/main/scala/org/apache/daffodil/unparsers/runtime1/BCDUnparsers.scala:
##########
@@ -69,11 +69,14 @@ final class BCDIntegerMinimumLengthUnparser(e:
ElementRuntimeData)
}
}
Review Comment:
Suggest we revert the changes in this file. You remove the functional
changes but left the formatting changes. I think the previous formatting was
more clear, and it's best to avoid format only changes in PRs. Makes it more
clear what actually changed, and also makes things like `git blame` work better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
