stevedlawrence commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2411541064
##########
src/launchWizard/launchWizard.ts:
##########
@@ -535,10 +535,21 @@ class LaunchWizard {
})
let dfdlDebugger: DFDLDebugger = defaultValues.dfdlDebugger
+
+ let debuggerVersionSelect = ''
+ let debuggerAllowedVersions = ['2', '3']
+ let debuggerVersion = dfdlDebugger.version
+ debuggerAllowedVersions.forEach((version) => {
+ if (version === debuggerVersion) {
+ debuggerVersionSelect += `<option selected
value="${version}">${version}</option>`
+ } else {
+ debuggerVersionSelect += `<option
value="${version}">${version}</option>`
+ }
+ })
Review Comment:
I thinking letting the user input to provide whatever version they want
would. This has the added benefit that if a new version of Daffodil is released
you don't necessarily need to install a new version of the extension. Just
update the version and the extension will download it from ASF infrastructure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
