stevedlawrence commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2417492813
##########
debugger/src/main/scala/org.apache.daffodil.debugger.dap/Utils.scala:
##########
@@ -70,3 +72,64 @@ object DataLeftOverUtils {
leftOverBitsText + dataHex + dataText
}
}
+
+/** Download and extract utils */
+object DownloadExtractUtils {
Review Comment:
It's probably a bit more user friendly to test in the bash script and exit
early with an error message and exit code indicating it failed to start. That
way we don't have to spin up a JVM that we know is going to fail at some point.
And the error message would probably be more helpful than a ClassNotFound
exception.
And I guess that means DAPodil doesn't need any options about
daffodilVersion or anything? And it just assumes that the classpath is set up
correctly and it uses whatever daffodil version is available. And if the
classpath isn't setup correctly then it will create a ClassNotFound exception.
But that should be unlikely if people are running the script correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
