stevedlawrence commented on code in PR #20:
URL:
https://github.com/apache/daffodil-infrastructure/pull/20#discussion_r2519347226
##########
actions/release-candidate/dist/main/index.js:
##########
@@ -31950,14 +31985,42 @@ async function run() {
fs.appendFileSync(`${ sbt_dir }/plugins/build.sbt`,
'addSbtPlugin("com.github.sbt" % "sbt-pgp" % "2.1.2")\n');
fs.appendFileSync(`${ sbt_dir }/build.sbt`, `pgpSigningKey :=
Some("${ gpg_signing_key_id }")\n`);
- // enable SBT for publishing SBOM
+ // enable SBT for publishing SBOM either locally or remotely
fs.appendFileSync(`${ sbt_dir }/plugins/build.sbt`,
'addSbtPlugin("com.github.sbt" %% "sbt-sbom" % "0.4.0")\n');
fs.appendFileSync(`${ sbt_dir }/build.sbt`, 'bomFormat :=
"xml"\n');
- if (publish) {
+ let svn_config_dir = "";
+ if (do_publish) {
+ // if publishing is enabled, we must configure sbt to
write to a config file for
+ // post to read from
+ const svn_username = core.getInput("svn_username", {
required: true });
+ const svn_password = core.getInput("svn_password", {
required: true });
+
+ // Create a temporary config directory
+ svn_config_dir = `${ os.tmpdir }/svn-config`
Review Comment:
Yeah, I think it's fine to overwrite existing files. I doubt there is
anything useful we need in the existing files. I would recommend we use
`servers` if that's what svn uses by default, that way actions running any
custom svn commands don't need know to use custom configs or supply
usernames/passwords.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
