Ontiomacer opened a new pull request, #1564: URL: https://github.com/apache/daffodil-vscode/pull/1564
Closes #1563 This change adds profile source target selection to the Data Editor, allowing profiling requests to be explicitly scoped to the selected target rather than implicitly using the active editor state. The intent is to make profiling behavior deterministic and prepare the UI for follow-on work in the Data Metrics view, where multiple profiling contexts may coexist. This aligns with the issue discussion around clarifying and controlling the profiling source. Changes include: Wiring target selection through the data editor client Updating the Data Metrics Svelte component to respect the selected profiling target Preserving existing behavior when no explicit target is set Wiki I have determined that no documentation updates are needed for these changes I have added the following documentation for these changes Review Instructions including Screenshots Launch the extension in the Extension Development Host. Open a binary file in the Data Editor. Trigger profiling from the Data Metrics panel. Change the profiling target and re-run profiling. Verify that the metrics update according to the selected target and no longer depend on editor focus. (UI behavior can be observed directly in the Data Metrics panel; screenshots can be added if requested.) ## Description This change introduces explicit profile source target selection in the Data Editor. Profiling requests are now scoped to the selected target rather than implicitly depending on editor focus, making profiling behavior deterministic and easier to extend in the Data Metrics view. Existing behavior is preserved when no explicit target is selected. Confirmation Testing Built the extension locally using the standard compile workflow. Verified profiling requests are issued with the correct target. Manually tested target switching using a sample binary file in the Data Editor. Confirmed no regressions in existing profiling behavior when using the default target. Regression Testing Opened and profiled existing data files without selecting a target to ensure legacy behavior is unchanged. Verified Data Metrics rendering remains consistent across reloads and editor focus changes. <img width="1366" height="768" alt="Screenshot From 2025-12-18 22-12-35" src="https://github.com/user-attachments/assets/80cd6b35-55dd-4d95-9df3-c1eb41de2f14"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
