stevedlawrence commented on code in PR #183:
URL: https://github.com/apache/daffodil-sbt/pull/183#discussion_r3191059456
##########
src/main/scala/org/apache/daffodil/DaffodilPlugin.scala:
##########
@@ -63,6 +70,18 @@ object DaffodilPlugin extends AutoPlugin {
val daffodilTdmlUsesPackageBin = settingKey[Boolean](
"Whether or not TDML files use the saved parsers created by
daffodilPackageBin"
)
+ val flattenTarget = settingKey[File](
+ "File to write the flattened schemas package to"
+ )
+ val flattenSchemas = taskKey[File](
+ "flatten the directory structure of all schemas and schema dependencies
to a single common directory and update 'schemaLocation' paths to match"
+ )
+ val flattenExcludes = settingKey[Seq[Glob]](
+ "Globs of paths to exclude from schema flattening"
+ )
+ val flattenIncludes = settingKey[Seq[Glob]](
+ "Globs of paths to include for schema flattening, even if the path is
listed in flattenExcludes"
+ )
Review Comment:
It's probably still useful to have `includeFilter` so that the file type
extensions that we care about aren't hard coded into the plugin. We can default
the setting to the extensions we want to support by default, but making it a
setting allows users to change it if they have a different set of file
extensions without changes to the plugin.
I think `excludeFilter` is also possibly useful if a project has files that
uses extensions we care about, but some of those files really shouldn't be
flattened. I don't think we have projects with that, and I don't know what they
would be, so the default value of `excludeFilter` can be an empty filter, but
it makes things configurable for just in case they might needed it. And the
code isn't significantly more complicated since the filter just becomes
something like:
```scala
val filter = includeFilter -- execludeFilter
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
