stevedlawrence commented on code in PR #1717:
URL: https://github.com/apache/daffodil/pull/1717#discussion_r3865352745
##########
daffodil-core/src/main/scala/org/apache/daffodil/lib/util/MStack.scala:
##########
@@ -33,35 +33,25 @@ object MStack {
* catches improper initialization. These were not initializing properly,
* so the idiom evolved to use the scala initializers.
*/
-final class MStackOfBoolean private ()
Review Comment:
I wouldn't do a real diagnostic. Something like maxSizeReached is probably
reasonable. And also probably not something that wants to be enabled by
default, since it's not necessarily wrong to grow the stack. But if there's a
stack that we default to 32 but it always grows to thousands it would be good
to know that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
