alamb commented on code in PR #10088:
URL: https://github.com/apache/datafusion/pull/10088#discussion_r1575269612
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -895,6 +891,31 @@ fn convert_to_sort_cols(
.collect::<Vec<_>>()
}
+fn replace_order_by_clause(order_by: &mut String) {
Review Comment:
I see -- `create_function_physical_name` doesn't have sufficient information
(`Expr`s etc to do this)
I suppose the alternate is to remember the relevant parts of the expression,
but that also seems brittle.
I can't think of anything better at the moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
