This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new 7119ee8cd2 Implement builder style API for ParserOptions (#14887)
7119ee8cd2 is described below
commit 7119ee8cd21207b6e09e695c05b6fe79a7f5eeed
Author: kosiew <[email protected]>
AuthorDate: Wed Feb 26 23:41:38 2025 +0800
Implement builder style API for ParserOptions (#14887)
* feat: enhance ParserOptions with new builder api
* refactor: update ParserOptions to use default method for initialization
* Add documentation for the fields
* refactor: remove unused getter methods from ParserOptions
---
datafusion/sql/src/planner.rs | 71 +++++++++++++++++++++++++++++++++++++++++--
1 file changed, 69 insertions(+), 2 deletions(-)
diff --git a/datafusion/sql/src/planner.rs b/datafusion/sql/src/planner.rs
index 5fb6ef913d..fdbb3229f4 100644
--- a/datafusion/sql/src/planner.rs
+++ b/datafusion/sql/src/planner.rs
@@ -43,15 +43,30 @@ pub use datafusion_expr::planner::ContextProvider;
/// SQL parser options
#[derive(Debug, Clone, Copy)]
pub struct ParserOptions {
+ /// Whether to parse float as decimal.
pub parse_float_as_decimal: bool,
+ /// Whether to normalize identifiers.
pub enable_ident_normalization: bool,
+ /// Whether to support varchar with length.
pub support_varchar_with_length: bool,
+ /// Whether to normalize options value.
pub enable_options_value_normalization: bool,
+ /// Whether to collect spans
pub collect_spans: bool,
}
-impl Default for ParserOptions {
- fn default() -> Self {
+impl ParserOptions {
+ /// Creates a new `ParserOptions` instance with default values.
+ ///
+ /// # Examples
+ ///
+ /// ```
+ /// use datafusion_sql::planner::ParserOptions;
+ /// let opts = ParserOptions::new();
+ /// assert_eq!(opts.parse_float_as_decimal, false);
+ /// assert_eq!(opts.enable_ident_normalization, true);
+ /// ```
+ pub fn new() -> Self {
Self {
parse_float_as_decimal: false,
enable_ident_normalization: true,
@@ -60,6 +75,58 @@ impl Default for ParserOptions {
collect_spans: false,
}
}
+
+ /// Sets the `parse_float_as_decimal` option.
+ ///
+ /// # Examples
+ ///
+ /// ```
+ /// use datafusion_sql::planner::ParserOptions;
+ /// let opts = ParserOptions::new().with_parse_float_as_decimal(true);
+ /// assert_eq!(opts.parse_float_as_decimal, true);
+ /// ```
+ pub fn with_parse_float_as_decimal(mut self, value: bool) -> Self {
+ self.parse_float_as_decimal = value;
+ self
+ }
+
+ /// Sets the `enable_ident_normalization` option.
+ ///
+ /// # Examples
+ ///
+ /// ```
+ /// use datafusion_sql::planner::ParserOptions;
+ /// let opts = ParserOptions::new().with_enable_ident_normalization(false);
+ /// assert_eq!(opts.enable_ident_normalization, false);
+ /// ```
+ pub fn with_enable_ident_normalization(mut self, value: bool) -> Self {
+ self.enable_ident_normalization = value;
+ self
+ }
+
+ /// Sets the `support_varchar_with_length` option.
+ pub fn with_support_varchar_with_length(mut self, value: bool) -> Self {
+ self.support_varchar_with_length = value;
+ self
+ }
+
+ /// Sets the `enable_options_value_normalization` option.
+ pub fn with_enable_options_value_normalization(mut self, value: bool) ->
Self {
+ self.enable_options_value_normalization = value;
+ self
+ }
+
+ /// Sets the `collect_spans` option.
+ pub fn with_collect_spans(mut self, value: bool) -> Self {
+ self.collect_spans = value;
+ self
+ }
+}
+
+impl Default for ParserOptions {
+ fn default() -> Self {
+ Self::new()
+ }
}
/// Ident Normalizer
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
